Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure if CONFIG_DRM_VC4_HDMI_CEC is disabled (trivial patch included) #4771

Closed
asavah opened this issue Dec 14, 2021 · 1 comment
Closed

Comments

@asavah
Copy link

asavah commented Dec 14, 2021

Describe the bug
If VC4_HDMI_CEC is disabled in kernel config build fails
Edit: using branch rpi-5.10.y

To reproduce
Build the kernel with aforementioned option disabled

Expected behaviour
Clean build

Actual behaviour

grep VC4_HDMI_CEC .config
# CONFIG_DRM_VC4_HDMI_CEC is not set
drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_cec_resume’:
drivers/gpu/drm/vc4/vc4_hdmi.c:2333:16: error: ‘return’ with a value, in function returning void [-Werror=return-type]
 2333 |         return 0;
      |                ^
drivers/gpu/drm/vc4/vc4_hdmi.c:2331:13: note: declared here
 2331 | static void vc4_hdmi_cec_resume(struct vc4_hdmi *vc4_hdmi)
      |             ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_runtime_resume’:
drivers/gpu/drm/vc4/vc4_hdmi.c:2573:13: error: void value not ignored as it ought to be
 2573 |         ret = vc4_hdmi_cec_resume(vc4_hdmi);
      |             ^
cc1: some warnings being treated as errors

Patch:

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 6aa074714305..b621fc3b1750 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -2328,7 +2328,7 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi)
 
 static void vc4_hdmi_cec_exit(struct vc4_hdmi *vc4_hdmi) {};
 
-static void vc4_hdmi_cec_resume(struct vc4_hdmi *vc4_hdmi)
+static int vc4_hdmi_cec_resume(struct vc4_hdmi *vc4_hdmi)
 {
 	return 0;
 }
@pelwell
Copy link
Contributor

pelwell commented Dec 14, 2021

Thanks!

pelwell added a commit that referenced this issue Dec 14, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Dec 14, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 16, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 16, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix added a commit to raspberrypi/firmware that referenced this issue Dec 17, 2021
kernel: ASoC:ma120x0p: Increase maximum sample rate to 192KHz
See: ASoC:ma120x0p: Increase maximum sample rate to 192KHz

kernel: Add cam0 parameter to image sensor overlays
See: Add cam0 parameter to image sensor overlays

kernel: drm/vc4: Fix build without DRM_VC4_HDMI_CEC
See: raspberrypi/linux#4771

kernel: v2 fix for the VLI TRB cache bug
See: raspberrypi/linux#4768

kernel: ARM: dts: Create bcm2711-rpi-cm4s.dts
See: raspberrypi/linux#4761

kernel: vc4/drm: Ignore vc4_hdmi->output_enabled for allowing audio
See: raspberrypi/linux#4759

kernel: media: imx219: Advertise embedded data node on media pad 1
See: raspberrypi/linux#4758
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this issue Dec 17, 2021
kernel: ASoC:ma120x0p: Increase maximum sample rate to 192KHz
See: ASoC:ma120x0p: Increase maximum sample rate to 192KHz

kernel: Add cam0 parameter to image sensor overlays
See: Add cam0 parameter to image sensor overlays

kernel: drm/vc4: Fix build without DRM_VC4_HDMI_CEC
See: raspberrypi/linux#4771

kernel: v2 fix for the VLI TRB cache bug
See: raspberrypi/linux#4768

kernel: ARM: dts: Create bcm2711-rpi-cm4s.dts
See: raspberrypi/linux#4761

kernel: vc4/drm: Ignore vc4_hdmi->output_enabled for allowing audio
See: raspberrypi/linux#4759

kernel: media: imx219: Advertise embedded data node on media pad 1
See: raspberrypi/linux#4758
popcornmix pushed a commit that referenced this issue Dec 17, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 22, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 22, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 31, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 31, 2021
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 5, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 5, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 10, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 11, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 11, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 11, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 11, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 17, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 17, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 24, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 24, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 25, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 25, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 28, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 28, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 31, 2022
As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jan 31, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 27, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 4, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 4, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
herrnst pushed a commit to herrnst/linux-raspberrypi that referenced this issue Jul 10, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: raspberrypi#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 11, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 11, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 18, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 18, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Jul 22, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Jul 23, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 1, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 1, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 1, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Aug 12, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Aug 12, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 15, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 15, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Aug 15, 2022
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: #4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Aug 18, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Aug 18, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
papamoose pushed a commit to papamoose/ubuntu-kernel-raspi-jammy that referenced this issue Sep 3, 2022
BugLink: https://bugs.launchpad.net/bugs/1958146

As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

(cherry picked from commit 4d3aab4c5918280b2dadff717721d2252b6a0739 rpi-5.15.y)
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Sep 30, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Dec 17, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Dec 17, 2022
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Apr 20, 2023
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue May 19, 2023
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Jun 20, 2023
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
wanghao75 pushed a commit to gitee2github/raspberrypi-kernel that referenced this issue Jul 13, 2023
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this issue Nov 29, 2023
As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this issue Apr 30, 2024
Pi0-3 have power domains attached to the pm_runtime hooks
for the HDMI block. Initialisation done in the reset called
from bind is therefore lost if all users of the domain are
suspended.
The VEC shares the same lowest level clock/power gating as
the HDMI block, so whilst that is enabled the block is never
actually powered down, but if it isn't enabled then we lose
the state.

Reset and initialise the HDMI block from pm_resume.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

drm/vc4: Fix build without DRM_VC4_HDMI_CEC

As reported by @asavah.

Fixes: raspberrypi/linux#4771

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants