Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing driver for rtc-rv3032 #5205

Closed
Gadgetoid opened this issue Oct 11, 2022 · 2 comments
Closed

Missing driver for rtc-rv3032 #5205

Gadgetoid opened this issue Oct 11, 2022 · 2 comments

Comments

@Gadgetoid
Copy link
Contributor

Describe the bug

Missing support in i2c-rtc.dtbo for the rv3032 RTC.

Steps to reproduce the behaviour

Add:

dtoverlay=i2c-rtc,rv3032

To /boot/config.txt

Device (s)

Raspberry Pi 4 Mod. B

System

cat /etc/rpi-issue 
Raspberry Pi reference 2022-04-04
Generated using pi-gen, https://github.com/RPi-Distro/pi-gen, 226b479f8d32919c9fe36dd5b4c20c02682f8180, stage4

vcgencmd version
Aug 26 2022 14:03:16 
Copyright (c) 2012 Broadcom
version 102f1e848393c2112206fadffaaf86db04e98326 (clean) (release) (start)

uname -a
Linux inkypi 5.15.61-v7l+ #1579 SMP Fri Aug 26 11:13:03 BST 2022 armv7l GNU/Linux

Logs

No response

Additional context

A working module for rtc-rv3032 exists. I have built it with DKMS and modified the dtbo accordingly. Setting and getting time via hwclock is successful.

I believe this needs adding to i2c-rtc-common.dtsi:

        fragment@21 {
                target = <&i2cbus>;
                __dormant__ {
                        #address-cells = <1>;
                        #size-cells = <0>;

                        rv3032: rv3032@51 {
                                compatible = "microcrystal,rv3032";
                                reg = <0x51>;
                        };
                };
        };

Plus the rtc-rv3032 module added to the build.

If you need/want a sample RTC board, let me know!

pelwell added a commit that referenced this issue Oct 12, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Oct 12, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented Oct 12, 2022

That should be done now - see d8eacff and f0f6d95.

Thanks for the offer, but I don't think I need more RTC modules - things in the RTC world rarely change.

@Gadgetoid
Copy link
Contributor Author

things in the RTC world rarely change

They are.. indeed... not exciting. 😆

Thank you very much!

Shout if you need anything.

popcornmix added a commit to raspberrypi/firmware that referenced this issue Oct 12, 2022
kernel: configs: Add RTC_DRV_RV3032=m
kernel: overlays: i2c-rtc: Add RV3032 support
See: raspberrypi/linux#5205
pelwell added a commit that referenced this issue Oct 16, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Oct 16, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Oct 16, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Oct 16, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 17, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 17, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 17, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 17, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 25, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 25, 2022
See: #5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell pelwell closed this as completed Oct 31, 2022
lsahn-gh pushed a commit to lsahn-org/ubuntu-raspi that referenced this issue Jan 13, 2023
BugLink: https://bugs.launchpad.net/bugs/1995968

See: raspberrypi/linux#5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

(cherry picked from commit 72b663ddb06840e620659f069504a64bfdb27f3f rpi-5.19.y)
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Acked-by: Cory Todd <cory.todd@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
lsahn-gh pushed a commit to lsahn-org/ubuntu-raspi that referenced this issue Jan 13, 2023
BugLink: https://bugs.launchpad.net/bugs/1995968

See: raspberrypi/linux#5205

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

(cherry picked from commit 9e5fee2d193ef1da6ae946c07824ddbc1e5b3fa0 rpi-5.19.y)
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Acked-by: Cory Todd <cory.todd@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants