Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing FSIA6B driver/module. #5208

Closed
pgold opened this issue Oct 15, 2022 · 5 comments
Closed

Missing FSIA6B driver/module. #5208

pgold opened this issue Oct 15, 2022 · 5 comments

Comments

@pgold
Copy link

pgold commented Oct 15, 2022

Describe the bug

The fsia6b driver is not available on Raspberry Pi's Linux kernel build.

Steps to reproduce the behaviour

When trying to load the fsia6b module:
$ sudo modprobe fsia6b

I get the following message: "modprobe: FATAL: Module fsia6b not found in directory /lib/modules/5.4.0-1071-raspi"

Device (s)

Raspberry Pi 4 Mod. B

System

cat /etc/rpi-issue (not available, I'm using Ubuntu 20.04).

$ vcgencmd version

Nov 18 2021 16:17:39 
Copyright (c) 2012 Broadcom
version d9b293558b4cef6aabedcc53c178e7604de90788 (clean) (release) (start_x)
$ uname -a

Linux roompi 5.4.0-1071-raspi #81-Ubuntu SMP PREEMPT Mon Sep 26 15:53:11 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

Logs

No response

Additional context

I'm trying to use inputattach with a fsia6b compatible controller, but it does not work unless the kernel module is loaded. It works if I build the module out-of-tree and insmod it, but it'd be nice if the module was part of the build (I see that other joystick drivers are included already).

Happy to open PRs if it is agreed that the driver should be added as a module to the kernel.

@pelwell
Copy link
Contributor

pelwell commented Oct 15, 2022

I'm happy to add a missing module, but 5.4 has already been superceded by two major kernel versions - 5.10 and 5.15. Even if we add the required config setting in rpi-5.4.y (which shouldn't really happen because it is in legacy, bug fix only mode), would it make its way into an Ubuntu release?

@pgold
Copy link
Author

pgold commented Oct 15, 2022

Thanks for looking into it, @pelwell .

Regarding the kernel version, I agree that it should only be added to the last one (for my particular use case, I plan on upgrading to Ubuntu 22.04 soon (linux 5.15)).

I'd expect it to make to an Ubuntu release, as 20.04 is an LTS version and AFAIK they still push new 5.4.y kernels.

pelwell added a commit that referenced this issue Oct 16, 2022
See: #5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Oct 16, 2022
See: #5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Oct 16, 2022
See: #5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented Oct 16, 2022

The fsia6b module has been enabled in all current (non-oldstable) branches.

@pgold
Copy link
Author

pgold commented Oct 17, 2022

Many thanks, @pelwell !

@pgold pgold closed this as completed Oct 17, 2022
popcornmix pushed a commit that referenced this issue Oct 17, 2022
See: #5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Oct 17, 2022
See: #5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@juergh
Copy link
Contributor

juergh commented Oct 17, 2022

FWIW, Ubuntu is not following the raspberrypi kernel configs so rpi config changes won't make it magically into an Ubuntu kernel. @pgold You need to open an Ubuntu bug for that: https://bugs.launchpad.net/ubuntu/+source/linux-raspi/+filebug

popcornmix added a commit to raspberrypi/firmware that referenced this issue Oct 18, 2022
…t.txt for start.elf

firmware: arm-dt: bootloader: Pass the original partition number when booting a ramdisk

firmware: arm_loader: HAT EEPROM support for GPIO bank 1
See: #1756

kernel: drivers/gpu/drm/vc4: Add missing 32-bit RGB formats
See: raspberrypi/linux#5209

kernel: ARM: dts: Add nvmem node for BCM2711 bootloader public key
See: raspberrypi/linux#5206

kernel: configs: Add FSIA6B driver module
See: raspberrypi/linux#5208
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this issue Oct 18, 2022
…t.txt for start.elf

firmware: arm-dt: bootloader: Pass the original partition number when booting a ramdisk

firmware: arm_loader: HAT EEPROM support for GPIO bank 1
See: raspberrypi/firmware#1756

kernel: drivers/gpu/drm/vc4: Add missing 32-bit RGB formats
See: raspberrypi/linux#5209

kernel: ARM: dts: Add nvmem node for BCM2711 bootloader public key
See: raspberrypi/linux#5206

kernel: configs: Add FSIA6B driver module
See: raspberrypi/linux#5208
popcornmix pushed a commit that referenced this issue Oct 25, 2022
See: #5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
lsahn-gh pushed a commit to lsahn-org/ubuntu-raspi that referenced this issue Jan 13, 2023
BugLink: https://bugs.launchpad.net/bugs/1995968

See: raspberrypi/linux#5208

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

(cherry picked from commit bffce270380803538ef0a791e3d2b8d61fb95e8c rpi-5.19.y)
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Acked-by: Cory Todd <cory.todd@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants