Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dummy output with hifiberry sound card #5763

Closed
tartanpion opened this issue Nov 30, 2023 · 18 comments
Closed

dummy output with hifiberry sound card #5763

tartanpion opened this issue Nov 30, 2023 · 18 comments

Comments

@tartanpion
Copy link

tartanpion commented Nov 30, 2023 •
edited

Describe the bug

No sound after kernel linux-rpi4 6.1.64-1 or linux-rpi4-mainline 6.6.3-1
aplay -l
**** Liste des périphériques matériels PLAYBACK **** carte 0 : sndrpihifiberry [snd_rpi_hifiberry_dacplus], périphérique 0 : HiFiBerry DAC+ Pro HiFi pcm512x-hifi-0 [HiFiBerry DAC+ Pro HiFi pcm512x-hifi-0] Sous-périphériques : 1/1 Sous-périphérique #0 : subdevice #0

Steps to reproduce the behaviour

Install new kernel

Device (s)

Raspberry Pi 4 Mod. B

System

Linux bloodmoon-pc 6.6.3-1-MANJARO-RPI4 #1 SMP PREEMPT Thu Nov 30 12:20:36 UTC 2023 aarch64 GNU/Linux

config.txt

`# Enable audio (loads snd_bcm2835)

force_eeprom_read=0
dtoverlay=
#dtparam=audio=on
dtoverlay=hifiberry-dacplus
`

Logs

`
nov. 30 22:22:32 bloodmoon-pc wireplumber[1534]: [0:00:40.819045770] [1534] ERROR IPAModule ipa_module.cpp:172 Symbol ipaModuleInfo not found

nov. 30 22:22:32 bloodmoon-pc wireplumber[1534]: [0:00:40.819115363] [1534] ERROR IPAModule ipa_module.cpp:292 v4l2-compat.so: IPA module has no valid info
nov. 30 22:22:32 bloodmoon-pc wireplumber[1534]: [0:00:40.819239844] [1534] INFO Camera camera_manager.cpp:284 libcamera v0.1.0
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc bluetoothd[441]: Failed to add UUID: Failed (0x03)
nov. 30 22:22:32 bloodmoon-pc bluetoothd[441]: Failed to add UUID: Failed (0x03)
`

Additional context

No response
@pelwell
Copy link
Contributor

pelwell commented Nov 30, 2023

Is the 6.1.64 kernel also mainline?

And what's the most recent kernel you can remember with working sound? You may find something in the system logs (perhaps from journalctl).

@tartanpion
Copy link
Author

Working sound with all the kernels before. Last good kernels : linux-rpi4 6.1.63-1 or linux-rpi4-mainline 6.6.2-1.
Mainline is just the name for manjaro to differentiate 6.1/6.6.

@pelwell
Copy link
Contributor

pelwell commented Nov 30, 2023

Thanks - that helps a lot.

@Dark-Sky
Copy link

Dark-Sky commented Dec 1, 2023

nov. 30 22:22:32 bloodmoon-pc wireplumber[1534]: [0:00:40.819115363] [1534] ERROR IPAModule ipa_module.cpp:292 v4l2-compat.so: IPA module has no valid info
nov. 30 22:22:32 bloodmoon-pc wireplumber[1534]: [0:00:40.819239844] [1534] INFO Camera camera_manager.cpp:284 libcamera v0.1.0

At least this looks like it is getting blamed on an ARCH-ARM packaging issue here:

https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3411

Tag me here if I need to compile a test kernel for the OP.

@pelwell
Copy link
Contributor

pelwell commented Dec 1, 2023

Interesting, but it's the later error messages that looked more relevant:

nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22
nov. 30 22:22:32 bloodmoon-pc kernel: pcm512x 1-004d: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004d: -22

@HiassofT
Copy link
Contributor

HiassofT commented Dec 1, 2023 •
edited

From a quick test this commit 1985fab which landed in 6.6.3 and 6.1.64 seems to be triggering that - I also noticed that on LibreELEC with kernel 6.6.3 on RPi5 and 6.1.64 on RPi4

[   13.206401] pcm512x 1-004c: Failed to sync cache: -22
[   13.211506] pcm512x 1-004c: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004c: -22

EDIT: using an iqaudio DAC here (guess pretty much all pcm512x cards should be affected)

@pelwell
Copy link
Contributor

pelwell commented Dec 1, 2023

Thanks, @HiassofT. Can you confirm that reverting that commit fixes the problem?

@HiassofT
Copy link
Contributor

HiassofT commented Dec 1, 2023

yes, with the commit reverted pcm512x is back to normal

LibreELEC:~ # dmesg | grep pcm512x
[   11.153738] pcm512x 1-004c: No SCLK, using BCLK: -2

and I have working audio (RPi5, LibreELEC master, kernel 6.6.3)

pelwell added a commit that referenced this issue Dec 1, 2023
@pelwell
Revert "regmap: Ensure range selector registers are updated after cac…
c02c4f5 
…he sync"

This reverts commit 164fa9a.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented Dec 1, 2023

That's great - it's reverted on rpi-6.1.y. and on its way to the others.

pelwell added a commit that referenced this issue Dec 1, 2023
@pelwell
Revert "regmap: Ensure range selector registers are updated after cac…
7bbbfb8 
…he sync"

This reverts commit 117ccba.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Dec 1, 2023
@pelwell
Revert "regmap: Ensure range selector registers are updated after cac…
63e3cff 
…he sync"

This reverts commit 1985fab.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue Dec 1, 2023
@pelwell
Revert "regmap: Ensure range selector registers are updated after cac…
9a2c160 
…he sync"

This reverts commit 0ec7731.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@tartanpion
Copy link
Author

I have working audio too after the revert.

@pelwell
Copy link
Contributor

pelwell commented Dec 1, 2023

Cool. That reversion will remain in our kernel builds until the problem is fixed upstream.

You can close the issue if you feel the matter has been dealt with.

@HiassofT
Copy link
Contributor

HiassofT commented Dec 1, 2023

@pelwell I've reported the issue upstream https://lore.kernel.org/stable/ZWo45hiK-n8W_yWJ@camel3.lan/

@pelwell
Copy link
Contributor

pelwell commented Dec 1, 2023

Thanks - I think your proposed patch will be the accepted fix.

@HiassofT
Copy link
Contributor

HiassofT commented Dec 3, 2023 •
edited

I've submitted the fix, hope it dribbles down to stable soon
https://lore.kernel.org/lkml/20231203222216.96547-1-hias@horus.com/T/#u

popcornmix pushed a commit that referenced this issue Dec 5, 2023
@pelwell @popcornmix
Revert "regmap: Ensure range selector registers are updated after cac…
1ef5f1f 
…he sync"

This reverts commit 0ec7731.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 5, 2023
@pelwell @popcornmix
Revert "regmap: Ensure range selector registers are updated after cac…
64ad1ac 
…he sync"

This reverts commit 1985fab.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Dec 5, 2023
@pelwell @popcornmix
Revert "regmap: Ensure range selector registers are updated after cac…
84411d2 
…he sync"

This reverts commit 117ccba.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix added a commit to raspberrypi/firmware that referenced this issue Dec 5, 2023
@popcornmix
kernel: Bump to 6.1.65
3d5ffbf 
kernel: overlays: ADS1115: allow specification of the i2c bus
See: raspberrypi/linux#5762

kernel: Add panel-dsi for device-tree side configuration of generic DSI panels
See: raspberrypi/linux#5640

kernel: Revert: regmap: Ensure range selector registers are updated after cache sync
See: raspberrypi/linux#5763

kernel: ASoC: Adds support for TAS575x to the pcm512x driver
kernel: ASoC: pcm512x: Adds bindings for TAS575x devices
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this issue Dec 5, 2023
@popcornmix
kernel: Bump to 6.1.65
d16727d 
kernel: overlays: ADS1115: allow specification of the i2c bus
See: raspberrypi/linux#5762

kernel: Add panel-dsi for device-tree side configuration of generic DSI panels
See: raspberrypi/linux#5640

kernel: Revert: regmap: Ensure range selector registers are updated after cache sync
See: raspberrypi/linux#5763

kernel: ASoC: Adds support for TAS575x to the pcm512x driver
kernel: ASoC: pcm512x: Adds bindings for TAS575x devices
popcornmix pushed a commit that referenced this issue Dec 8, 2023
@pelwell @popcornmix
Revert "regmap: Ensure range selector registers are updated after cac…
e063007 
…he sync"

This reverts commit 1985fab.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@HiassofT
Copy link
Contributor

HiassofT commented Dec 9, 2023

@pelwell @popcornmix quick heads up: the upstream fix will be in the next stable kernels, Greg just added it to his queues

popcornmix pushed a commit that referenced this issue Dec 11, 2023
@pelwell @popcornmix
Revert "regmap: Ensure range selector registers are updated after cac…
4e1a563 
…he sync"

This reverts commit 1985fab.

The reverted commit breaks at least some I2C-based soundcards, and
possibly much more. Thanks for pointing the finger, HiassofT.

See: #5763
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@HiassofT
Copy link
Contributor

The fix is now upstream in 6.1.68/6.6.7 kernels.

@popcornmix could you please update rpi 6.1 and 6.6 branches?

@pelwell
Copy link
Contributor

pelwell commented Dec 14, 2023

That's done now - thanks for the diagnosis, and for getting a fix upstreamed so rapidly.

@pelwell
Copy link
Contributor

pelwell commented Dec 14, 2023

Oh dear - re-reading your message I should just have waited for the next merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HiassofT @tartanpion @pelwell @Dark-Sky