clk-bcm2835-aux fix - backported from kernel 4.6 #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce() The change fixes potential oops while accessing iomem on invalid address, if devm_ioremap_resource() fails due to some reason. The devm_ioremap_resource() function returns ERR_PTR() and never returns NULL, which makes useless a following check for NULL. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Fixes: 5e63dcc ("clk: bcm2835: Add a driver for the auxiliary peripheral clock gates") Reviewed-by: Eric Anholt <eric@anholt.net> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Closed
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Apr 22, 2016
See: raspberrypi/linux#1419 kernel: clk-bcm2835-aux fix - backported from kernel 4.6 See: raspberrypi/linux#1423 kernel: bcm2835-i2s: Reduce the TX DREQ threshold See: raspberrypi/linux#1417 kernel: config: Add DRM_UDL module See: raspberrypi/linux#1422 kernel: vchiq_arm: Add completion records under the mutex See: https://discourse.osmc.tv/t/crashing-when-seeking/15716 firmware: pwm_sdm: Fix release build bug regression See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445 firmware: raspistill: Use camera_info component to set the sensor name and output resolution firmware: dtoverlay: Require sudo for destructive operations firmware: dtoverlay: command line tweaks See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: platform: Move initial freq settings to platform firmeare: platform: Move initial volt settings to platform
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Apr 22, 2016
See: raspberrypi/linux#1419 kernel: clk-bcm2835-aux fix - backported from kernel 4.6 See: raspberrypi/linux#1423 kernel: bcm2835-i2s: Reduce the TX DREQ threshold See: raspberrypi/linux#1417 kernel: config: Add DRM_UDL module See: raspberrypi/linux#1422 kernel: vchiq_arm: Add completion records under the mutex See: https://discourse.osmc.tv/t/crashing-when-seeking/15716 firmware: pwm_sdm: Fix release build bug regression See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445 firmware: raspistill: Use camera_info component to set the sensor name and output resolution firmware: dtoverlay: Require sudo for destructive operations firmware: dtoverlay: command line tweaks See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: platform: Move initial freq settings to platform firmeare: platform: Move initial volt settings to platform
XECDesign
pushed a commit
to RPi-Distro/firmware
that referenced
this pull request
May 4, 2016
See: raspberrypi/linux#1419 kernel: clk-bcm2835-aux fix - backported from kernel 4.6 See: raspberrypi/linux#1423 kernel: bcm2835-i2s: Reduce the TX DREQ threshold See: raspberrypi/linux#1417 kernel: config: Add DRM_UDL module See: raspberrypi/linux#1422 kernel: vchiq_arm: Add completion records under the mutex See: https://discourse.osmc.tv/t/crashing-when-seeking/15716 firmware: pwm_sdm: Fix release build bug regression See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445 firmware: raspistill: Use camera_info component to set the sensor name and output resolution firmware: dtoverlay: Require sudo for destructive operations firmware: dtoverlay: command line tweaks See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: platform: Move initial freq settings to platform firmeare: platform: Move initial volt settings to platform
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
See: raspberrypi/linux#1419 kernel: clk-bcm2835-aux fix - backported from kernel 4.6 See: raspberrypi/linux#1423 kernel: bcm2835-i2s: Reduce the TX DREQ threshold See: raspberrypi/linux#1417 kernel: config: Add DRM_UDL module See: raspberrypi/linux#1422 kernel: vchiq_arm: Add completion records under the mutex See: https://discourse.osmc.tv/t/crashing-when-seeking/15716 firmware: pwm_sdm: Fix release build bug regression See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445 firmware: raspistill: Use camera_info component to set the sensor name and output resolution firmware: dtoverlay: Require sudo for destructive operations firmware: dtoverlay: command line tweaks See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: platform: Move initial freq settings to platform firmeare: platform: Move initial volt settings to platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clk: bcm2835: fix check of error code returned by devm_ioremap_resource()
The change fixes potential oops while accessing iomem on invalid address, if devm_ioremap_resource() fails due to some reason.
The devm_ioremap_resource() function returns ERR_PTR() and never returns NULL, which makes useless a following check for NULL.
Signed-off-by: Vladimir Zapolskiy vz@mleia.com
Fixes: 5e63dcc ("clk: bcm2835: Add a driver for the auxiliary peripheral clock gates")
Reviewed-by: Eric Anholt eric@anholt.net
Signed-off-by: Stephen Boyd sboyd@codeaurora.org