Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audioinjector-octo: revert to dummy supplies #2834

Merged
merged 1 commit into from Jan 29, 2019
Merged

audioinjector-octo: revert to dummy supplies #2834

merged 1 commit into from Jan 29, 2019

Conversation

flatmax
Copy link
Contributor

@flatmax flatmax commented Jan 29, 2019

The Audio Injector Octo has had a lot of reports of not coming up on power cycles. By reverting to dummy supplies, the card comes up reliably.

The Audio Injector Octo has had a lot of reports of not coming up on power cycles. By reverting to dummy supplies, the card comes up reliably.
@flatmax
Copy link
Contributor Author

flatmax commented Jan 30, 2019

Thanks for merging. I was wondering does this patch get integrated into the 4.19 kernel as well ?

@pelwell
Copy link
Contributor

pelwell commented Jan 30, 2019

It would/should have been picked up by the next asynchronous batch cherry-pick, but it's in there now (and 4.20 and 5.0).

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 5, 2019
kernel: audioinjector-octo: revert to dummy supplies
See: raspberrypi/linux#2834
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Feb 5, 2019
kernel: audioinjector-octo: revert to dummy supplies
See: raspberrypi/linux#2834
@nettings
Copy link

Problem persists with current 4.19. Ran rpi-update today, which pulled

Linux mn_d1bb0b 4.19.34-v7+ #1211 SMP Mon Apr 8 22:56:37 BST 2019 armv7l GNU/Linux

Audioinjector Octo did not come up after four reboots with

[    6.781955] audioinjector-octo soc:sound: ASoC: CODEC DAI cs42448 not registered - will retry
[    6.781967] audioinjector-octo soc:sound: snd_soc_register_card failed (-517)
[    7.763464] IPv6: ADDRCONF(NETDEV_CHANGE): medianet0: link becomes ready
[    8.351931] audioinjector-octo soc:sound: ASoC: CODEC DAI cs42448 not registered - will retry
[    8.351940] audioinjector-octo soc:sound: snd_soc_register_card failed (-517)

Manually removing all relevant audio modules after boot and reinserting them as instructed by flatmax fixes the issue reliably (i.e. 5 out of 5 tries so far). So it looks like a boot-up timing issue.
For the record, here is the modprobe sequence again:

sudo modprobe -r snd_soc_audioinjector_octo_soundcard
sudo modprobe -r snd_soc_cs42xx8_i2c
sudo modprobe -r snd_soc_cs42xx8
sudo modprobe snd_soc_cs42xx8
sudo modprobe snd_soc_cs42xx8_i2c
sudo modprobe snd_soc_audioinjector_octo_soundcard

@pelwell
Copy link
Contributor

pelwell commented Apr 21, 2019

I think you're actually seeing a different problem (Audio-Injector/Octo#14), for which I have a proposed fix (#2902). If you can build your own kernel with that patch and confirm it works then I'll merge it.

@nettings
Copy link

Thanks for the clarification - I thought the issues were related, since they came up in the same thread... I looked at #2902, but it doesn't seem to apply cleanly to the latest tree, and I don't know enough to resolve this. How do I find the latest kernel tree where this patch applies cleanly? Downgrading the kernel temporarily to test this would be no problem.

@pelwell
Copy link
Contributor

pelwell commented Apr 22, 2019

I'll rebase the patch when I get back to a keyboard, but until then you can cherry-pick 3f92162 onto rpi-4.19.y.

@pelwell
Copy link
Contributor

pelwell commented Apr 23, 2019

You can download a patch file suitable for git am <file> from GitHub by opening a commit and appending .patch to the URL, e.g. https://github.com/raspberrypi/linux/commit/3f92162f7d4d3d4c1ba5a086f90d9b56acbf6419.patch

@nettings
Copy link

Thanks, that's a very useful thing to know. Building now.

@nettings
Copy link

Three warm reboots, two cold reboots, card comes up reliably each time. Thanks!

For the record, I'm seeing kernel: bcm2835-i2s 3f203000.i2s: I2S SYNC error! twice each time I start jack, but that was already the case on an unpatched 4.19.23-v7+. Will investigate next if that shuffles the channels around...

@nettings
Copy link

When is this fix going to land in an "rpi-update"-able kernel?

@pelwell
Copy link
Contributor

pelwell commented Apr 23, 2019

Now that the patch has been merged, I would expect it to be in a release by the end of the week.

@nettings
Copy link

Ok, the I2S SYNC error!seems to be benign. I haven't ever seen shuffled channels after a clean reboot.

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Apr 23, 2019
kernel: audioinjector-octo: revert to dummy supplies
See: raspberrypi/linux#2834

kernel: sound: Fixes for audioinjector-octo under 4.19
See: raspberrypi/linux#2902

kernel: Maxim MAX98357A I2S DAC overlay
See: raspberrypi/linux#2935

kernel: Add DVBSky S960 patch to fix broken driver
See: raspberrypi/linux#2849
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Apr 23, 2019
kernel: audioinjector-octo: revert to dummy supplies
See: raspberrypi/linux#2834

kernel: sound: Fixes for audioinjector-octo under 4.19
See: raspberrypi/linux#2902

kernel: Maxim MAX98357A I2S DAC overlay
See: raspberrypi/linux#2935

kernel: Add DVBSky S960 patch to fix broken driver
See: raspberrypi/linux#2849
@popcornmix
Copy link
Collaborator

@nettings rpi-update kernel now contains this fix.

@nettings
Copy link

@popcornmix, thanks, I can confirm it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants