Amend init order of TPM and IMA modules #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change seeks to correct the load order of a TPM and IMA (Integrity Measurement Architecture). Currently IMA loads first, which results in it not seeing the TPM and using the TPM as a means to store measurements. The order of `core_initcall` and `subsys_initcall` are reversed within `drivers/clk/bcm/clk-bcm2835.c` and `drivers/firmware/raspberrypi.c` to achieve this. Resolves: #3291 Signed-off-by: Luke Hinds <lhinds@redhat.com>
|
I have two problems with this commit:
I think it would be safer to delay the clock driver to initcall_postcore, as that is less likely to have unintended consequences. |
|
@lukehinds Any comment on the @pelwell comment? |
|
I've added a commit that moves the clock driver to postcore_initcall. If there are no objections I'll merge this once the next stable snapshot has been taken. |
pelwell
added
Assigned for implementation/action
Waiting for internal comment
|
looks good to me. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 22, 2020
kernel: sound: Add the HiFiBerry DAC+HD version See: raspberrypi/linux#3418 kernel: Fixup rpimem to cleanly unload and reload, and make checkpatch clean See: raspberrypi/linux#3419 kernel: Amend init order of TPM and IMA modules See: raspberrypi/linux#3297 kernel: net: usb: lan78xx: Add .ndo_features_check See: raspberrypi/linux#3395 firmware: platform: Only throttle down from arm_freq firmware: platform: Bump desired ring osc to 3.7 on Pi3/CM3 firmware: arm_loader: Add 2ms delay before resetting SD_IO
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 22, 2020
kernel: sound: Add the HiFiBerry DAC+HD version See: raspberrypi/linux#3418 kernel: Fixup rpimem to cleanly unload and reload, and make checkpatch clean See: raspberrypi/linux#3419 kernel: Amend init order of TPM and IMA modules See: raspberrypi/linux#3297 kernel: net: usb: lan78xx: Add .ndo_features_check See: raspberrypi/linux#3395 firmware: platform: Only throttle down from arm_freq firmware: platform: Bump desired ring osc to 3.7 on Pi3/CM3 firmware: arm_loader: Add 2ms delay before resetting SD_IO
pelwell
pushed a commit
that referenced
this pull request
Jan 23, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
pelwell
pushed a commit
that referenced
this pull request
Jan 24, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Jan 30, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Jan 30, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 6, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 6, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 20, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 20, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 25, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 25, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
kraj
pushed a commit
to kraj/linux-raspberrypi
that referenced
this pull request
Feb 25, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: raspberrypi#3291 raspberrypi#3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 6, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 10, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 10, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 23, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 23, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 23, 2020
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 19, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 27, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 27, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Mar 27, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 3, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 5, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 5, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 8, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 11, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 16, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 16, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 18, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 23, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 29, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Apr 29, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
jai-raptee
pushed a commit
to jai-raptee/iliteck1
that referenced
this pull request
Apr 30, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: raspberrypi/linux#3291 raspberrypi/linux#3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
jai-raptee
pushed a commit
to jai-raptee/iliteck1
that referenced
this pull request
Apr 30, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: raspberrypi/linux#3291 raspberrypi/linux#3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
jai-raptee
pushed a commit
to jai-raptee/iliteck1
that referenced
this pull request
Apr 30, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: raspberrypi/linux#3291 raspberrypi/linux#3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
jai-raptee
pushed a commit
to jai-raptee/iliteck1
that referenced
this pull request
Apr 30, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: raspberrypi/linux#3291 raspberrypi/linux#3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
jai-raptee
pushed a commit
to jai-raptee/iliteck1
that referenced
this pull request
Apr 30, 2024
The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: raspberrypi/linux#3291 raspberrypi/linux#3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
May 2, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
May 13, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
May 20, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
May 20, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
May 28, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
May 28, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Jun 3, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Jun 3, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Jun 3, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
popcornmix
pushed a commit
that referenced
this pull request
Jun 10, 2024
so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> clk: clk-bcm2835: Use %zd when printing size_t The debug text for how many clocks have been registered uses "%d" with a size_t. Correct it to "%zd". Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Initialise rpi-firmware before clk-bcm2835 The IMA (Integrity Measurement Architecture) looks for a TPM (Trusted Platform Module) having been registered when it initialises; otherwise it assumes there is no TPM. It has been observed on BCM2835 that IMA is initialised before TPM, and that initialising the BCM2835 clock driver before the firmware driver has the effect of reversing this order. Change the firmware driver to initialise at core_initcall, delaying the BCM2835 clock driver to postcore_initcall. See: #3291 #3297 Signed-off-by: Luke Hinds <lhinds@redhat.com> Co-authored-by: Phil Elwell <phil@raspberrypi.org> clk-bcm2835: use subsys_initcall for the clock driver when IMA is enabled Co-authored-by: Davide Scovotto <scovottodavide@gmail.com> Co-developed-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Davide Scovotto <scovottodavide@gmail.com> Signed-off-by: Alberto Solavagione <albertosolavagione30@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seeks to correct the load order of a TPM and
IMA (Integrity Measurement Architecture).
Currently IMA loads first, which results in it not seeing the TPM
and using the TPM as a means to store measurements.
The order of
core_initcallandsubsys_initcallare reversedwithin
drivers/clk/bcm/clk-bcm2835.canddrivers/firmware/raspberrypi.cto achieve this.Resolves: #3291
Signed-off-by: Luke Hinds lhinds@redhat.com