xhci: quirks: add link TRB quirk for VL805 #3929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VL805 controller can't cope with the TR Dequeue Pointer for an endpoint being set to a Link TRB. The hardware-maintained endpoint context ends up stuck at the address of the Link TRB, leading to erroneous ring expansion events whenever the enqueue pointer wraps to the dequeue position. If the search for the end of the current TD and ring cycle state lands on a Link TRB, move to the next segment. See: raspberrypi#3919 Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
|
Is this the naive fix mentioned in #3919, and if so does it still break the bulk IN endpoint in some way? |
|
It's now less naive - the issue with the hasty fix was that I didn't account for the case where the link trb also toggled the ring cycle state. 5k iterations of the test loop pass OK with this patch. |
|
Thanks. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 26, 2020
See: raspberrypi/Raspberry-Pi-OS-64bit#4 kernel: rpisense-fb: Set pseudo_pallete to prevent crash on fbcon takeover See: raspberrypi/linux#3931 kernel: xhci: quirks: add link TRB quirk for VL805 See: raspberrypi/linux#3929 kernel: Allow the headphone output to be disabled See: raspberrypi/linux#3928
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Oct 26, 2020
See: raspberrypi/Raspberry-Pi-OS-64bit#4 kernel: rpisense-fb: Set pseudo_pallete to prevent crash on fbcon takeover See: raspberrypi/linux#3931 kernel: xhci: quirks: add link TRB quirk for VL805 See: raspberrypi/linux#3929 kernel: Allow the headphone output to be disabled See: raspberrypi/linux#3928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VL805 controller can't cope with the TR Dequeue Pointer for an endpoint
being set to a Link TRB. The hardware-maintained endpoint context ends up
stuck at the address of the Link TRB, leading to erroneous ring expansion
events whenever the enqueue pointer wraps to the dequeue position.
If the search for the end of the current TD and ring cycle state lands on
a Link TRB, move to the next segment.
See: #3919
Signed-off-by: Jonathan Bell jonathan@raspberrypi.com