-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bcm2835-isp: Add colour denoise mode config #4083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a configuration structure for colour denoise to the bcm2835_isp driver. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Add colour denoise control to the bcm2835 driver through a new v4l2 control: V4L2_CID_USER_BCM2835_ISP_CDN. Add the accompanying MMAL configuration structure definitions as well. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Yes, once the build check is complete |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 21, 2021
kernel: bcm2835-isp: Add colour denoise mode config See: raspberrypi/linux#4069 kernel: configs: Enable BCM2835 thermal driver in kernel8 See: raspberrypi/linux#4077 firmware: Export bootloader config via device-tree firmware: ISP: Colour denoise See: raspberrypi/linux#4083
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 21, 2021
kernel: bcm2835-isp: Add colour denoise mode config See: raspberrypi/linux#4069 kernel: configs: Enable BCM2835 thermal driver in kernel8 See: raspberrypi/linux#4077 firmware: Export bootloader config via device-tree firmware: ISP: Colour denoise See: raspberrypi/linux#4083
kbingham
pushed a commit
to kbingham/libcamera
that referenced
this pull request
Feb 9, 2021
Update the bcm2835-isp.h file with the latest version available in the downstream Raspberry Pi linux repo at commit: 68878170d8a98afd6d519a3a2c909080c19de4ce This change adds support for colour denoise processing, and the following downstream kernel changes must be available: raspberrypi/linux#4069 raspberrypi/linux#4083 The Raspberry Pi image must also be running the latest firmware, obtained by running rpi-update. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
naushir
added a commit
to raspberrypi/libcamera
that referenced
this pull request
Feb 14, 2021
Update the bcm2835-isp.h file with the latest version available in the downstream Raspberry Pi linux repo at commit: 68878170d8a98afd6d519a3a2c909080c19de4ce This change adds support for colour denoise processing, and the following downstream kernel changes must be available: raspberrypi/linux#4069 raspberrypi/linux#4083 The Raspberry Pi image must also be running the latest firmware, obtained by running rpi-update. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4069 needs to be back-ported to the 5.4 tree.