Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcm2835-isp: Add colour denoise mode config #4083

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

naushir
Copy link
Contributor

@naushir naushir commented Jan 20, 2021

#4069 needs to be back-ported to the 5.4 tree.

Add a configuration structure for colour denoise to the bcm2835_isp
driver.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Add colour denoise control to the bcm2835 driver through a new v4l2
control: V4L2_CID_USER_BCM2835_ISP_CDN.

Add the accompanying MMAL configuration structure definitions as well.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
@naushir
Copy link
Contributor Author

naushir commented Jan 20, 2021

@pelwell, could you merge this if you are happy with the change? This is identical to #4069.

@pelwell
Copy link
Contributor

pelwell commented Jan 20, 2021

Yes, once the build check is complete

@pelwell pelwell merged commit 08ae2dd into raspberrypi:rpi-5.4.y Jan 20, 2021
@naushir naushir deleted the cdn-5.4.y branch January 20, 2021 10:04
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jan 21, 2021
kernel: bcm2835-isp: Add colour denoise mode config
See: raspberrypi/linux#4069

kernel: configs: Enable BCM2835 thermal driver in kernel8
See: raspberrypi/linux#4077

firmware: Export bootloader config via device-tree

firmware: ISP: Colour denoise
See: raspberrypi/linux#4083
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Jan 21, 2021
kernel: bcm2835-isp: Add colour denoise mode config
See: raspberrypi/linux#4069

kernel: configs: Enable BCM2835 thermal driver in kernel8
See: raspberrypi/linux#4077

firmware: Export bootloader config via device-tree

firmware: ISP: Colour denoise
See: raspberrypi/linux#4083
kbingham pushed a commit to kbingham/libcamera that referenced this pull request Feb 9, 2021
Update the bcm2835-isp.h file with the latest version available in the
downstream Raspberry Pi linux repo at commit:
68878170d8a98afd6d519a3a2c909080c19de4ce

This change adds support for colour denoise processing, and the
following downstream kernel changes must be available:
raspberrypi/linux#4069
raspberrypi/linux#4083

The Raspberry Pi image must also be running the latest firmware,
obtained by running rpi-update.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
naushir added a commit to raspberrypi/libcamera that referenced this pull request Feb 14, 2021
Update the bcm2835-isp.h file with the latest version available in the
downstream Raspberry Pi linux repo at commit:
68878170d8a98afd6d519a3a2c909080c19de4ce

This change adds support for colour denoise processing, and the
following downstream kernel changes must be available:
raspberrypi/linux#4069
raspberrypi/linux#4083

The Raspberry Pi image must also be running the latest firmware,
obtained by running rpi-update.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants