net: phy: lan87xx: Allow more time for link detect #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With EDPWRDOWN set in idle, it must be cleared before checking for ENERGYON going high, indicating that a link is being established. The existing code allows 640ms for ENERGYON to go high, but on Raspberry Pis that appears not to be enough, causing link detection to fail. Increase the polling timeout to 1500ms - with a polling interval of 10ms it shouldn't cause unnecessary delays. See: raspberrypi#4393 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
s/lan87xx/lan78xx |
|
Oh joys, they've mixed and matched 8700 and 7800. Lovely! I was just about to note that the LAN7800 is only on the 3B+, not the 3B the linked issue references. |
|
LAN87xx is the PHY. |
|
Hence: @@ -195,12 +195,12 @@ static int lan87xx_read_status(struct phy_device *phydev) |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 23, 2021
See: raspberrypi/linux#4593 kernel: rpivid: Ensure IRQs have completed before uniniting context See: raspberrypi/linux#4599 kernel: net: phy: lan87xx: Allow more time for link detect See: raspberrypi/linux#4598
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Sep 23, 2021
See: raspberrypi/linux#4593 kernel: rpivid: Ensure IRQs have completed before uniniting context See: raspberrypi/linux#4599 kernel: net: phy: lan87xx: Allow more time for link detect See: raspberrypi/linux#4598
|
Excuse me, I meant 1ce8b37. The other one is a fixup for that commit. |
|
Thanks, Lukas - we're always happy to drop downstream patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With EDPWRDOWN set in idle, it must be cleared before checking for
ENERGYON going high, indicating that a link is being established.
The existing code allows 640ms for ENERGYON to go high, but on
Raspberry Pis that appears not to be enough, causing link detection
to fail.
Increase the polling timeout to 1500ms - with a polling interval of
10ms it shouldn't cause unnecessary delays.
See: #4393
Signed-off-by: Phil Elwell phil@raspberrypi.com