net: phy: broadcom: Make LEDs 3+4 shadow LEDs 1+2 #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CM4 uses BCM54210PE, which supports 2 additional LEDs, choosing LED3 for the amber LED because it shows activity by default (LED4 is not connected). However, this makes it uncontrollable by the eth_led<n> dtparams which target LEDs 1+2. Solve the problem by making LEDs 3+4 mirror LEDs 1+2 (which is much simpler than adding baseboard-specific overrides, but comes with a risk of making one of the LEDs redundant). See: raspberrypi#5289 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 4, 2023
See: https://forums.raspberrypi.com/viewtopic.php?p=2067109#p2067109 kernel: overlays: i2c-sensor: MS temp & pressure sensors See: raspberrypi/linux#5301 kernel: overlays: audremap: Fix setting of the pin function See: raspberrypi/linux#5294 kernel: net: phy: broadcom: Make LEDs 3+4 shadow LEDs 1+2 See: raspberrypi/linux#5300 kernel: drm/vc4: Fix YUV plane handling when planes are in different buffers See: raspberrypi/linux#5299 kernel: Restore dropped support for Innolux panel See: raspberrypi/linux#5288
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 4, 2023
See: https://forums.raspberrypi.com/viewtopic.php?p=2067109#p2067109 kernel: overlays: i2c-sensor: MS temp & pressure sensors See: raspberrypi/linux#5301 kernel: overlays: audremap: Fix setting of the pin function See: raspberrypi/linux#5294 kernel: net: phy: broadcom: Make LEDs 3+4 shadow LEDs 1+2 See: raspberrypi/linux#5300 kernel: drm/vc4: Fix YUV plane handling when planes are in different buffers See: raspberrypi/linux#5299 kernel: Restore dropped support for Innolux panel See: raspberrypi/linux#5288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM4 uses BCM54210PE, which supports 2 additional LEDs, choosing LED3 for the amber LED because it shows activity by default (LED4 is not connected). However, this makes it uncontrollable by the eth_led dtparams which target LEDs 1+2.
Solve the problem by making LEDs 3+4 mirror LEDs 1+2 (which is much simpler than adding baseboard-specific overrides, but comes with a risk of making one of the LEDs redundant).
See: #5289
Signed-off-by: Phil Elwell phil@raspberrypi.com