Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCP23017: allow specification of the i2c bus #5650

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

janisstreib
Copy link
Contributor

@janisstreib janisstreib commented Oct 15, 2023

Analogous to i2c-rtc-overlay.dts

Copy link
Contributor

@pelwell pelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good so far. There's one minor in-line comment, but otherwise I'd just like you to add the other i2c buses as well, so that it properly matches i2c-rtc.

@@ -57,13 +57,22 @@
microchip,irq-mirror;
};
};
frag100: fragment@100 {
target = <&i2c_arm>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i2c_arm isn't wrong, but let's keep it as i2c1 anyway for regularity (and because i2c_arm only exists after the firmware has added it as an alias for i2c1).

@janisstreib janisstreib changed the title MCP23017: allow the specification of the i2c bus MCP23017: allow specification of the i2c bus Oct 15, 2023
@janisstreib
Copy link
Contributor Author

Thank you very much! I've used the wrong branch as template for the i2c block. I've amended the suggested changes analogous to this branch's I2C DTS.

@janisstreib janisstreib force-pushed the rpi-6.1.y branch 4 times, most recently from 7f133a3 to 80a43dc Compare October 15, 2023 14:37
Analogous to i2c-rtc-overlay.dts
@janisstreib
Copy link
Contributor Author

janisstreib commented Oct 15, 2023

Sorry for the multiple amends afterwards; I needed to fix my formatting. I hope it's all good now 🙈

@pelwell pelwell merged commit 27f0e0e into raspberrypi:rpi-6.1.y Oct 15, 2023
11 of 12 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Oct 17, 2023
kernel: drivers: media: rp1_cfe: Fix link validate test for pixel format
See: raspberrypi/linux#5657

kernel: drm/vc4: Correct address offset for planes with src_[xy] offsets
See: raspberrypi/linux#5654

kernel: input: touchscreen: edt-ft5x06: Suppress bogus data on startup
See: raspberrypi/linux#5645

kernel: vc_mem: Add the DMA memcpy support from bcm2708_fb
See: raspberrypi/linux#5651

kernel: dts: bcm2712: Set default I2C baudrates to 100kHz
See: raspberrypi/linux#5653

kernel: MCP23017: allow specification of the i2c bus
See: raspberrypi/linux#5650

kernel: Revert: bcm2708_fb: Hack out dma support
See: raspberrypi/linux#5648

firmware: config: Add [pi5] to config.txt on 2711 and earlier platforms

userland: bcm_host: Update kms/fkms check for pi5
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Oct 17, 2023
kernel: drivers: media: rp1_cfe: Fix link validate test for pixel format
See: raspberrypi/linux#5657

kernel: drm/vc4: Correct address offset for planes with src_[xy] offsets
See: raspberrypi/linux#5654

kernel: input: touchscreen: edt-ft5x06: Suppress bogus data on startup
See: raspberrypi/linux#5645

kernel: vc_mem: Add the DMA memcpy support from bcm2708_fb
See: raspberrypi/linux#5651

kernel: dts: bcm2712: Set default I2C baudrates to 100kHz
See: raspberrypi/linux#5653

kernel: MCP23017: allow specification of the i2c bus
See: raspberrypi/linux#5650

kernel: Revert: bcm2708_fb: Hack out dma support
See: raspberrypi/linux#5648

firmware: config: Add [pi5] to config.txt on 2711 and earlier platforms

userland: bcm_host: Update kms/fkms check for pi5
pelwell pushed a commit that referenced this pull request Oct 19, 2023
pelwell pushed a commit that referenced this pull request Oct 19, 2023
popcornmix pushed a commit that referenced this pull request Oct 24, 2023
popcornmix pushed a commit that referenced this pull request Oct 24, 2023
popcornmix pushed a commit that referenced this pull request Oct 30, 2023
popcornmix pushed a commit that referenced this pull request Oct 30, 2023
popcornmix pushed a commit that referenced this pull request Nov 16, 2023
popcornmix pushed a commit that referenced this pull request Nov 16, 2023
popcornmix pushed a commit that referenced this pull request Nov 21, 2023
popcornmix pushed a commit that referenced this pull request Nov 21, 2023
popcornmix pushed a commit that referenced this pull request Nov 21, 2023
popcornmix pushed a commit that referenced this pull request Nov 29, 2023
popcornmix pushed a commit that referenced this pull request Nov 29, 2023
popcornmix pushed a commit that referenced this pull request Dec 5, 2023
popcornmix pushed a commit that referenced this pull request Dec 5, 2023
popcornmix pushed a commit that referenced this pull request Dec 8, 2023
popcornmix pushed a commit that referenced this pull request Dec 11, 2023
popcornmix pushed a commit that referenced this pull request Dec 14, 2023
popcornmix pushed a commit that referenced this pull request Dec 21, 2023
popcornmix pushed a commit that referenced this pull request Jan 2, 2024
popcornmix pushed a commit that referenced this pull request Jan 8, 2024
popcornmix pushed a commit that referenced this pull request Jan 11, 2024
popcornmix pushed a commit that referenced this pull request Jan 17, 2024
popcornmix pushed a commit that referenced this pull request Jan 22, 2024
popcornmix pushed a commit that referenced this pull request Jan 30, 2024
popcornmix pushed a commit that referenced this pull request Feb 6, 2024
popcornmix pushed a commit that referenced this pull request Feb 19, 2024
popcornmix pushed a commit that referenced this pull request Feb 23, 2024
popcornmix pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants