New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dts: bcm2712: put usb under /axi not /soc #5772

Merged

pelwell merged 1 commit into raspberrypi:rpi-6.1.y from P33M:2712_dwc

Dec 5, 2023

Contributor

P33M commented Dec 5, 2023

With dtoverlay=dwc2,dr_mode=host in /boot/firmware/config.txt, and the associated EEPROM firmware bump to turn the PHY on, I have a functional USB2 root port on the USB-C connector.

Still some rough edges if the port goes into suspend, which you get with a hub that has no occupied downstream ports.

Frequent "mode mismatch interrupt" spam
Disconnect interrupts aren't signalled.


          dts: bcm2712: put usb under /axi not /soc

86764e2

On 2712, the DWC USB controller is no longer attached to the Videocore
30-bit bus with its associated aliases, and can see the bottom 4GB of
RAM directly.

Ideally it should make use of IOMMU6 but for now software bounce buffers
get it working.

Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>

P33M force-pushed the 2712_dwc branch from b8a025f to 86764e2 Compare

December 5, 2023 17:35

pelwell merged commit 82069a7 into raspberrypi:rpi-6.1.y

12 checks passed

Contributor

6by9 commented Dec 5, 2023

Do we need to revert ff2db58 and 74d906b now so that we don't have a restricted DMA region with dwc2?

Contributor

pelwell commented Dec 5, 2023

We certainly can revert them, since the resulting dma zone will then be the first 4GB, matching the dwc2 range. To not do so, apart from retaining a spurious extra overlay, would unnecessarily limit the locations for the swiotlb bufffers, but that probably wouldn't be harmful (or even noticeable).

pelwell added a commit that referenced this pull request


          Revert "fixup! overlays: Add Pi 5 version of dwc2"

e8c0aa3

This reverts commit 74d906b.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

pelwell added a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

0ad213e

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

pelwell added a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

fb20163

This reverts commit 9869f8e.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

pelwell added a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

5e18b9c

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

6by9 mentioned this pull request

Pi 5 dwc2 overlay fails raspberrypi/bookworm-feedback#77

Closed

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

c6a0b9d

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix added a commit to raspberrypi/firmware that referenced this pull request


          kernel: Bump to 6.1.66

7e6decc

kernel: configs: rpi: Compile TSC2007 as module
See: raspberrypi/linux#5776

kernel: Cfe improvements
See: raspberrypi/linux#5632

kernel: Add support for Arducam OV64A40 64Mpx camera module
See: raspberrypi/linux#5708

kernel: 2712 MOP/MOPlet fixes
See: raspberrypi/linux#5773

kernel: dts: bcm2712: put usb under /axi not /soc
See: raspberrypi/linux#5772

popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request


          kernel: Bump to 6.1.66

d07a7a4

kernel: configs: rpi: Compile TSC2007 as module
See: raspberrypi/linux#5776

kernel: Cfe improvements
See: raspberrypi/linux#5632

kernel: Add support for Arducam OV64A40 64Mpx camera module
See: raspberrypi/linux#5708

kernel: 2712 MOP/MOPlet fixes
See: raspberrypi/linux#5773

kernel: dts: bcm2712: put usb under /axi not /soc
See: raspberrypi/linux#5772

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

b49c398

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

966bad9

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

007a496

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

c3665e1

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

a5dbf9b

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

78e3ee7

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

9ae6dfb

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

1caa6f8

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

02ceb9a

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

pelwell added a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

bb149aa

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

pelwell added a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

88c03b1

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

31f8c37

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

7e63f5a

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

77efcf3

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

4f9a191

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

faaa80d

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

3df3cca

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

6d60bfc

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

3c40428

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

a75d23f

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

e1385d8

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

7dec51b

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

8132aab

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

ec3b513

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

424b596

This reverts commit 72cd5ee.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

e2fed28

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

4450da1

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

3957e1a

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

fa12ef1

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

8ea3956

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

fhunleth added a commit to nerves-project/nerves_system_rpi5 that referenced this pull request


          dwc2-pi5.dtbo is no longer needed

59ea41c

See raspberrypi/linux#5772

pelwell added a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

3767e36

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

popcornmix pushed a commit that referenced this pull request


          Revert "overlays: Add Pi 5 version of dwc2"

0fc7a23

This reverts commit ff2db58.

We don't need a special dwc2 overlay for Pi 5, with a node to limit the
DMA zone to the first 1GB, since it turns out that the USB2 controller
has a 4GB range after all.

See #5772

Signed-off-by: Phil Elwell <phil@raspberrypi.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment