DRAFT: drm: rp1: rp1-vec: Add a parameter to set DRM picture aspect ratio #6166
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting picture_aspect_ratio field in advertised DRM modes. This has no other effect on VEC's behaviour. Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
6by9
reviewed
May 14, 2024
There was a problem hiding this comment.
Can we add validation that the module parameter is a valid enum hdmi_picture_aspect? https://elixir.bootlin.com/linux/latest/source/include/linux/hdmi.h#L96
| drm_mode_probed_add(connector, mode); | ||
| n++; | ||
|
|
||
| if (mode->vtotal == 405 || mode->vtotal == 819) | ||
| if (i >= 4) |
There was a problem hiding this comment.
This 4 is creeping in as a magic number both here and line 355. It'd be nice if it came from a define in and around the rp1vec_modes array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimentally, allow setting picture_aspect_ratio field in all advertised DRM modes. This has no other effect on VEC's behaviour (and perhaps has no useful effects at all...)
It is set via a module parameter
drm-rp1-vec.parwhich can be set from the command line, or later using sysfs. A value of 1 means 4:3, 2 means 16:9.