bugfix for 32kHz sample rate, was missing #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
added a commit
that referenced
this pull request
Feb 2, 2015
bugfix for 32kHz sample rate, was missing
pfpacket
pushed a commit
to pfpacket/linux-rpi-rust
that referenced
this pull request
Apr 7, 2023
rust: add basic rcu support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy one-line fix: the hifiberry_digi driver is not going down to 32 kHz audio sample rate (the lowest for S/PDIF), however the underlying WM8804 codec driver supports and advertises 32 kHz. This was inconsistant, resulted in out-of-pitch playback with 44.1 kHz because the application was thinking it's playing 32 kHz.
With this fix, such problems are gone, tested with aplay and mplayer, 32 kHz plays well. Below, mplayer does correct upsampling, before it was mislead.