WS2812: Support more than 7 pins in parallel mode #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws2812_parallel_program_init() contained an unneeded call to sm_config_set_set_pins(). When this is called with the pin_count parameter set to a value larger than 5, the set pin count value in the pinctrl register overflows into the side-set pin count. This can result in hard to diagnose issues where low numbered GPIO pins don't work as expected. There is an existing valid_params_if() check in sm_config_set_set_pins() which would catch this error but it is ignored in Release builds. This commit just removes this sm_config_set_set_pins() call as SET commands aren't even used by the associated PIO code. Discovered when trying to explain symptoms noted in this forum thread: https://forums.raspberrypi.com/viewtopic.php?t=362071
kilograham
approved these changes
Dec 31, 2023
adamgreen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws2812_parallel_program_init()contained an unneeded call tosm_config_set_set_pins(). When this is called with thepin_countparameter set to a value larger than 7, the set pin count value in the pinctrl register overflows into the side-set pin count. This can result in hard to diagnose issues where low numbered GPIO pins don't work as expected.There is an existing
valid_params_if()check insm_config_set_set_pins()which would catch this error but it is ignored in Release builds.This PR just removes this
sm_config_set_set_pins()call as SET commands aren't even used by the associated PIO code.Discovered when trying to explain symptoms noted in this forum thread