Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pico_bootsel_via_double_reset library, fix #87 #137

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Add pico_bootsel_via_double_reset library, fix #87 #137

merged 3 commits into from
Feb 18, 2021

Conversation

Wren6991
Copy link
Contributor

See #87. Pull in the double tap boot library from pico-examples, and add configs and doxygen.

I left the actual code unchanged, but wonder if it is worth adding a couple of compiler barriers.

@Wren6991 Wren6991 mentioned this pull request Feb 16, 2021
Merged
kilograham
kilograham requested changes Feb 16, 2021
View reviewed changes
src/rp2_common/pico_bootsel_via_double_reset/CMakeLists.txt Outdated Show resolved Hide resolved
src/rp2_common/CMakeLists.txt Outdated Show resolved Hide resolved
@kilograham kilograham linked an issue Feb 17, 2021 that may be closed by this pull request
boot stage2: double reset to uf2 #87
Closed
@kilograham kilograham added this to the 1.0.2 milestone Feb 17, 2021
kilograham
kilograham approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lurch
Copy link
Contributor

lurch commented Feb 18, 2021

Once this has been merged into the pico-sdk repo, will the corresponding code in pico-examples be updated to match?

@Wren6991
Copy link
Contributor Author

Once this has been merged into the pico-sdk repo, will the corresponding code in pico-examples be updated to match?

Yes, and that PR exists, and is linked to this PR. Scroll up

@Wren6991 Wren6991 merged commit 4c1fac5 into develop Feb 18, 2021
@Wren6991 Wren6991 deleted the add-boot-double-tap branch February 18, 2021 16:12
@hathach hathach mentioned this pull request Feb 18, 2021
Closed
@hathach
Copy link
Contributor

hathach commented Feb 18, 2021

Thank you for the PR, this will help small factor board with only 1 reset as button (BOOTSEL can be test pad for recover purpose) :)

kilograham pushed a commit that referenced this pull request Mar 5, 2021
@Wren6991 @kilograham
Add pico_bootsel_via_double_reset library, fix #87 (#137)
e513a27 
* Add pico_bootsel_via_double_reset library, fix #87

* pico_bootsel_via_double_reset: remove unnecessary library guard, fix subdirectory ordering

* Fix C type used as PICO_CONFIG type
kilograham pushed a commit that referenced this pull request Mar 5, 2021
@Wren6991 @kilograham
Add pico_bootsel_via_double_reset library, fix #87 (#137)
d492b72 
* Add pico_bootsel_via_double_reset library, fix #87

* pico_bootsel_via_double_reset: remove unnecessary library guard, fix subdirectory ordering

* Fix C type used as PICO_CONFIG type
@hathach hathach mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilograham kilograham kilograham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

boot stage2: double reset to uf2
4 participants
@Wren6991 @lurch @hathach @kilograham