Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for booting from a "superfloppy" disk #120

Closed
worproject opened this issue May 2, 2020 · 6 comments
Closed

Add support for booting from a "superfloppy" disk #120

worproject opened this issue May 2, 2020 · 6 comments
Labels
enhancement New feature or request low priority

Comments

@worproject
Copy link

The boot ROM itself can boot just fine from a superfloppy disk (i've tested this with the recovery.bin image), but if there's no recovery image on the disk, it loads the EEPROM bootloader which can only boot from MBR-partitioned disks.

This worked fine on the Pi 3 as the bootcode was loaded by the boot ROM directly from the SD card.

@timg236
Copy link
Collaborator

timg236 commented May 2, 2020

Yes, it's MBR only, maybe GPT in future, but that's low priority.

Adding support for niche features even if it was supported on earlier models increases code complexity and test burden so I'm marking this as not-going-to-fix

@timg236 timg236 added the wontfix This will not be worked on label May 2, 2020
@worproject
Copy link
Author

Indeed, GPT support would be better. In fact I was using superfloppy to workaround the lack of native GPT support.

@timg236
Copy link
Collaborator

timg236 commented May 2, 2020

Thanks that’s useful to know

@timg236 timg236 reopened this May 20, 2020
@timg236 timg236 added enhancement New feature or request low priority and removed wontfix This will not be worked on labels May 20, 2020
@timg236
Copy link
Collaborator

timg236 commented May 20, 2020

Since we are adding GPT and 0xef partition support we may as well add SuperFloppy whilst we are editing that bit of code.
Hopefully, fairly standard MBR (primary + extended) and GPT will then just work.

timg236 added a commit that referenced this issue May 26, 2020
* Resolve: USB boot fails if the GPT contains no basic data or EFI partitions #130
* Resolve: Fix default BOOT_ORDER in mass storage beta #129
* Resolve: Add support for booting from a "superfloppy" disk #120
* Resolve: USB MSD timeout message - incorrect units #131
* Resolve: Recognize efi partition (0xef) as a valid boot #126
* The HDMI diagnostics screen now displays the most significant bytes of the SHA-256 of the config.txt file.
@timg236
Copy link
Collaborator

timg236 commented May 26, 2020

This should be fixed by e87bc4d

The binaries are available in this release which can be flashed using the Raspberry Pi Imager
https://github.com/raspberrypi/rpi-eeprom/releases/tag/v2020.05.26-137ad

@timg236
Copy link
Collaborator

timg236 commented Jun 4, 2020

Fix is now available via rpi-eeprom apt package

@timg236 timg236 closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant