Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #216

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix dependencies #216

merged 1 commit into from
Sep 3, 2020

Conversation

MichaIng
Copy link

@MichaIng MichaIng commented Sep 2, 2020

rpi-eeprom-images is a transitional dummy package since v7.2 which pulls in rpi-eeprom >=7.2 as dependency only. It can be hence removed from rpi-eeprom dependencies.

@timg236
Copy link
Collaborator

timg236 commented Sep 3, 2020

N.B It's generally better to put the information in the commit text rather than the PR comment

@XECDesign Is this ok, otherwise, going to revert all of this and go back to /proc/cpuinfo

@MichaIng
Copy link
Author

MichaIng commented Sep 3, 2020

I usually put the same text into commit and PR comment, so did I here. Only thing I forgot in the commit was the reference to the issue, but in this trivial case I think it can be ignored.

Or do you mean the commit header/first line itself? I wanted to, but didn't find a good way to put the required information into a ~80 character sentence 😄. Let me know if you have a good idea and I'll amend it. There is a missing 7 anyway for v7.2.

@timg236
Copy link
Collaborator

timg236 commented Sep 3, 2020

@MichaIng Please ignore comment - I was fooled by the Github UI. It's fine :)

Just need @XECDesign to approve this but there's a beta being updated today so they can all go in the same update

rpi-eeprom-images is a transitional dummy package since v7.2 which pulls in rpi-eeprom >=7.2 as dependency only. It can be hence removed from rpi-eeprom dependencies.

Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng
Copy link
Author

MichaIng commented Sep 3, 2020

Due to 73e845d I amended the commit to only remove obsolete rpi-eeprom-images from the dependencies.

@XECDesign
Copy link
Collaborator

Yes, this looks okay. Thank you.

@timg236 timg236 merged commit e7006e0 into raspberrypi:debian/buster Sep 3, 2020
@MichaIng MichaIng deleted the patch-1 branch September 3, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants