Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Automatically set H.264 level 4.2 if needed #438

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

naushir
Copy link
Collaborator

@naushir naushir commented Jan 13, 2023

If the macroblocks/s exceed 245760, override the level option to "4.2".

Signed-off-by: Naushir Patuck naush@raspberrypi.com

@naushir
Copy link
Collaborator Author

naushir commented Jan 13, 2023

@njhollinghurst as requested.

core/video_options.hpp Outdated Show resolved Hide resolved
If the macroblocks/s exceed 245760, override the level option to "4.2".

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
@naushir
Copy link
Collaborator Author

naushir commented Jan 16, 2023

Fixed up the rounding, and added a conditional check on the codec type.

@naushir naushir merged commit dc86fee into raspberrypi:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants