image: Exif "Model" tags should store camera model, not ID #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be more in the spirit of the Exif and DNG specs to record the camera's "model" string, rather than its ID (which is neither a model nor a unique serial number), and to prefix a "Make" onto UniqueCameraModel.
The Make ("Raspberry Pi") is now a
#define
so that it can be overridden by Makefiles, but I'm happy to rework this.Before:
After:
Here are some possible reasons why we might not want this change: