rpicam_vid: handling SIGPIPE to avoid sporadic app termination #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, one final thing... could you wrap the commit message at 72 lines please? If you force push to your branch, this will automatically update the PR. |
SIGPIPE gets raised when trying to write to an already closed socket. This can happen, when you're using TCP to stream to VLC and the user presses the stop button in VLC. Catching the signal to be able to react on it, otherwise the app terminates. Signed-off-by: Thomas Ederer <thomas@orchideenvermehrung.at>
tederer
force-pushed
the
add_sigpipe_handling
branch
from
d064b33
to
b7fbac8
Compare
|
It should be there now :-)
Am 2024-01-31 10:23, schrieb naushir:
… Sorry, one final thing... could you wrap the commit message at 72
lines please? If you force push to your branch, this will
automatically update the PR.
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you authored the thread.Message ID:
***@***.***>
Links:
------
[1]
#637 (comment)
[2]
https://github.com/notifications/unsubscribe-auth/AFKV77IUDFUWH72LUTSX34DYRIERHAVCNFSM6AAAAABCSV457CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJYG4YDKOBTGA
|
|
Thanks for the fix. Now merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGPIPE gets raised when trying to write to an already closed socket. This can happen, when you're using TCP to stream to VLC and the user presses the stop button in VLC. Catching the signal to be able to react on it, otherwise the app terminates.