Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for network and fflush to decrease latency. #248

Merged
merged 1 commit into from Aug 25, 2015

Conversation

Kixunil
Copy link
Contributor

@Kixunil Kixunil commented Jun 24, 2015

These changes allow users to stream video directly over network with lower latency (bypassing pipes and buffers). If file name has format tcp://host:port then TCP connection to host:port is opened. Similarly if udp:// is used, UDP packets with data are sent to host:port.

@JamesH65
Copy link
Collaborator

Would it be possible to use the same bracketing style as the rest of the code please (Allman).

@popcornmix
Copy link
Contributor

Regularly calling fflush will reduce performance for the usual case (writing to sdcard) where we don't care about latency.

@JamesH65
Copy link
Collaborator

I'd suggest it would be worth putting the fflush as an optional parameter
just for those who need it..

On 24 June 2015 at 12:41, popcornmix notifications@github.com wrote:

Regularly calling fflush will reduce performance for the usual case
(writing to sdcard) where we don't care about latency.


Reply to this email directly or view it on GitHub
#248 (comment).

@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 22, 2015

Sorry to come back so late, I forgot about this PR. I fixed the braces and made optional switch to enable flushing. In case of other issues feel free to write me.

@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 23, 2015

Sorry, I used tabs in vim. Fixed it.

@popcornmix
Copy link
Contributor

Can you squash all commit to a single one and force push.
@JamesH65 @6by9 okay by you?

@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 23, 2015

@popcornmix Done, is it OK?

@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 23, 2015

Yeah, I prefer tabs and I'm very accustomed to using them. Sorry.

@JamesH65
Copy link
Collaborator

Using "f" as the short command line parameter conflicts with the preview -f
option - I'd suggest changing to -fl which I think is free. You need to
cross check with RaspiPreview.c, Raspistill/vid.c and RaspiCamControl.c to
find a 'spare' option.

On 23 August 2015 at 20:56, Martin Habovštiak notifications@github.com
wrote:

Yeah, I prefer tabs and I'm very accustomed to using them. Sorry.


Reply to this email directly or view it on GitHub
#248 (comment).

@6by9
Copy link
Contributor

6by9 commented Aug 24, 2015

Content looks fine to me other than James having picked up on the clash of -f in the option.

@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 24, 2015

@JamesH65 I didn't know that options should be conflict-free across different tools. I just changed it to -fl, as you suggested.

@JamesH65
Copy link
Collaborator

They are not different tools, as things like RaspiPreview are used across
multiple tools. Hence the requirement to keep things unique.

On 24 August 2015 at 22:36, Martin Habovštiak notifications@github.com
wrote:

@JamesH65 https://github.com/JamesH65 I didn't know that options should
be conflict-free across different tools. I just changed it to -fl, as you
suggested.


Reply to this email directly or view it on GitHub
#248 (comment).

@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 25, 2015

@JamesH65 OK, thanks for explanation!

popcornmix added a commit that referenced this pull request Aug 25, 2015
Added support for network and fflush to decrease latency.
@popcornmix popcornmix merged commit fb11b39 into raspberrypi:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants