-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lntop: update to v0.2.0 #821
Conversation
Update to latest release now that binaries are available. This change also adds binary signature verification. Deleting downloaded files is removed as these are small and the /tmp folder is purged on every reboot anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update! one more bonus guide which is up-to-date for v3 🥇
A couple of typo fixes and one suggestion to reassure user that the dashbaord can take a while to load.
Other than that, I think it could be beneficial to add a section that explains how to navigate the dashboard with the keyboard, using F1 (help), F2 (left menu), Enter, q (quit), a (sort column, ascending), d (sort column, descending). I think that'd be super helpful, particulalry because it's not easy to find the explanations. But we could do this with another PR later.
Other than that, I'm puzzled regarding the Go requirement. I thought Go was _not_installed by default on RasPiOS Lite.. so how come we can use lntop without installing Go first?
Addressed all your feedback, thanks!
Good idea! I think that could be another pull-request, though. We could open an issue for this as a reminder, with the "help wanted" tag. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
Update to latest release now that binaries are available.
Why
Version 0.2.0 of lntop adds some new features and bugfixes:
https://github.com/edouardparis/lntop/releases/tag/v0.2.0
This change also adds binary signature verification as best practice.
How
Simple update of download links, plus added instructions for checksum signature validation. See edouardparis/lntop#49 for some context.
Deleting downloaded files is removed as these are small and the /tmp folder is purged on every reboot anyway.
Scope
Test & maintenance
Follow instructions and run
lntop