Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lntop: update to v0.2.0 #821

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Conversation

Stadicus
Copy link
Collaborator

@Stadicus Stadicus commented Dec 4, 2021

What

Update to latest release now that binaries are available.

Why

Version 0.2.0 of lntop adds some new features and bugfixes:
https://github.com/edouardparis/lntop/releases/tag/v0.2.0

This change also adds binary signature verification as best practice.

How

Simple update of download links, plus added instructions for checksum signature validation. See edouardparis/lntop#49 for some context.

Deleting downloaded files is removed as these are small and the /tmp folder is purged on every reboot anyway.

Scope

  • significant change to core configuration
  • independent bonus guide
  • simple application update

Test & maintenance

Follow instructions and run lntop

Update to latest release now that binaries are available. This
change also adds binary signature verification.

Deleting downloaded files is removed as these are small and
the /tmp folder is purged on every reboot anyway.
@Stadicus Stadicus self-assigned this Dec 4, 2021
@Stadicus Stadicus added the application-update Update of 3rd-party application label Dec 4, 2021
Copy link
Collaborator

@VajraOfIndra VajraOfIndra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update! one more bonus guide which is up-to-date for v3 🥇

A couple of typo fixes and one suggestion to reassure user that the dashbaord can take a while to load.

Other than that, I think it could be beneficial to add a section that explains how to navigate the dashboard with the keyboard, using F1 (help), F2 (left menu), Enter, q (quit), a (sort column, ascending), d (sort column, descending). I think that'd be super helpful, particulalry because it's not easy to find the explanations. But we could do this with another PR later.

Other than that, I'm puzzled regarding the Go requirement. I thought Go was _not_installed by default on RasPiOS Lite.. so how come we can use lntop without installing Go first?

@Stadicus
Copy link
Collaborator Author

Stadicus commented Dec 6, 2021

Addressed all your feedback, thanks!

Other than that, I think it could be beneficial to add a section that explains how to navigate the dashboard with the keyboard, using F1 (help), F2 (left menu), Enter, q (quit), a (sort column, ascending), d (sort column, descending).

Good idea! I think that could be another pull-request, though. We could open an issue for this as a reminder, with the "help wanted" tag.

PTAL

Copy link
Collaborator

@VajraOfIndra VajraOfIndra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stadicus Stadicus merged commit 9621e7b into raspibolt:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-update Update of 3rd-party application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants