Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflicts #3798

Merged
merged 9 commits into from Aug 4, 2018
Merged

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Aug 3, 2018

Overview

This PR replaces our default dependency resolver with coursier, upgrades some libraries for
consistency (like getting to circe 0.9.1 and geotrellis 2.0.0-RC2), explicitly adds some deps that weren't
picked up transitively (scalaz), uses some doobie combinators where we previously had strings, and adds an explicit COURSIER_CACHE environment variable to docker-compose. More on that last bit in notes.

Checklist

  • PR has a name that won't get you publicly shamed for vagueness
  • Any new SQL strings have tests

Notes

The COURSIER_CACHE environment variable is useful for sandboxing -- it's now possible, if you want to try out changing some dependencies without having to worry about your cache state affecting results. You can specify a different COURSIER_CACHE and know that the result of your dependency
changes has nothing to do with prior state. Neat! I used it as a way to test library upgrades to see how
much work it would be to get them to work, then changed the cache back and didn't have to
do anything to get to my prior working state. I threw this variable into docker-compose.yml because I
think we're more likely to edit it and wanted it somewhere more obvious than .env, but I'm open to
criticism/ergonomics feedback on that front.

Testing Instructions

  • Delete everything in your .ivy cache (rm -rf app-backend/project/.ivy/cache/)
  • console into your api server
  • api/update
  • watch as dependency hell fails to take hold of your soul

Closes #3757

@jisantuc jisantuc changed the title wip -- Fix dependency conflicts Fix dependency conflicts Aug 3, 2018
Copy link
Contributor

@alkamin alkamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 🎉

@jisantuc jisantuc merged commit 01708bb into develop Aug 4, 2018
@jisantuc jisantuc deleted the feature/js/fix-dependency-conflicts branch August 4, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dependency Conflicts for Assembly Tasks [2]
2 participants