Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing ADR #5145

Merged
merged 6 commits into from
Sep 5, 2019
Merged

Add tracing ADR #5145

merged 6 commits into from
Sep 5, 2019

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Sep 3, 2019

Overview

This PR adds an ADR for tracing. It's rendered here

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Closes #5124

@jisantuc jisantuc changed the title [wip] Add tracing ADR summary Add tracing ADR summary Sep 4, 2019
@jisantuc jisantuc changed the title Add tracing ADR summary Add tracing ADR Sep 4, 2019
Copy link
Contributor

@notthatbreezy notthatbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel super strongly about the formatting, but think it is worth considering moving.

docs/architecture/adr-0028-tracing.md Outdated Show resolved Hide resolved
@jisantuc jisantuc merged commit 35094f8 into develop Sep 5, 2019
@jisantuc jisantuc deleted the feature/js/adr-tracing branch September 5, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ADR for Tracing
3 participants