Fix routing problem for scene detail tiles #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notthatbreezy
approved these changes
Oct 7, 2019
| y | ||
| ) :? BandOverrideQueryParamDecoder( | ||
| bandOverride | ||
| ) as user using tracingContext => |
There was a problem hiding this comment.
nice addition here removing the match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR dramatically DRYs out middleware application in
backsplash-server, eliminates some unnecessary middlewares, and kills a layer of matching in server routes.Checklist
Demo
Notes
I wanted it also to use
AutoSlashfromhttp4s.server.middlewarebut I couldn't figure out how to make that work. Given how much else I was able to light on 馃敟 I'm not worrying too much about it.The dramatic changes to middleware / http4s upgrade were to get the API to look as much like http4s documentation as possible and to decrease the surface area of "things that could be different between rendering scenes and projects". View changes without whitespace changes to get a sense of how much was trimmed.
Testing Instructions
;reload;backsplash-server/assembly(or justbacksplash-server/assemblyif you don't already have an sbt shell open)Closes azavea/raster-foundry-platform#857