New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Separate Pools for Raster IO + Cache #5219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #5200 we removed `parTraverse` because we had evidence that tiles with many IO operations were using up the default execution context threads and blocking on requests from S3. Before, we experimented with different execution contexts for the whole application, but not in specific circumstances. This commit introduces `parTraverse` back into our rendering and specifically uses a cached thread pool in this context. Additionally, the memcached client had an internal pool that was scaled based on the number of cores present. This PR adjusts that to also use a cached threadpool with the understanding that since this is IO we should not be limiting ourselves to the cores of the machine.
Lknechtli
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good once we switch to a smaller threadpool to avoid crushing gdal until we get geotiff raster sources working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #5200 we removed
parTraverse
because we had evidence that tileswith many IO operations were using up the default execution context
threads and blocking on requests from S3. Before, we experimented with
different execution contexts for the whole application, but not in
specific circumstances. This commit introduces
parTraverse
back intoour rendering and specifically uses a cached thread pool in this
context.
Additionally, the memcached client had an internal pool that was
scaled based on the number of cores present. This PR adjusts that to
also use a cached threadpool with the understanding that since this is
IO we should not be limiting ourselves to the cores of the machine.
Checklist
Notes
Load test from
develop
Load test from this PR
It doesn't move the needle that much, or if at all, but the story makes more sense I think conceptually without too much overhead in terms of complexity so I think it's still worth it.
I did test out using fibers, but there wasn't a noticeable bump and on the global execution context we were still running into issues around paralellizing the fetches to S3.
Testing Instructions
Closes #5199
Closes #5191