Add a new StatisticsError exception class #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make an outer `with Env():` optional when using an opened dataset as a context manager. Resolves #2759
sgillies
commented
Feb 8, 2023
| @@ -439,6 +440,7 @@ cdef class DatasetBase: | |||
| self._closed = True | |||
|
|
|||
| def __enter__(self): | |||
| self._env.enter_context(env_ctx_if_needed()) | |||
There was a problem hiding this comment.
I feel dumb for not seeing this until now. I could have done this for 1.3.0!
There was a problem hiding this comment.
dataset.enter_context(Env()) is like a retroactive version of
with Env():
with dataset as dataset:
...
It lets us add an outer context (Env()) to the inner one (dataset), from within the inner one.
sgillies
commented
Feb 8, 2023
| @@ -60,13 +60,13 @@ def xy( | |||
| col : int | |||
| Pixel column. | |||
| z : float, optional | |||
| Height associated with coordinates. Primarily used for RPC based | |||
| coordinate transformations. Ignored for affine based | |||
There was a problem hiding this comment.
I looked in this module to remind myself how I was using ExitStack and found some trailing whitespace to remove. It's related 😉
sgillies
commented
Feb 8, 2023
| @@ -72,16 +68,6 @@ def test_dataset_readonly_attributes(path_rgb_byte_tif): | |||
| dataset.crs = "foo" | |||
|
|
|||
|
|
|||
| def test_statistics(path_rgb_byte_tif): | |||
There was a problem hiding this comment.
Moved to its own test module.
sgillies
commented
Feb 8, 2023
| _ = dataset.statistics(1) | ||
|
|
||
| captured = capsys.readouterr() | ||
| assert "ERROR 1" not in captured.err |
There was a problem hiding this comment.
Without the change to _base.pyx, this assertion fails.
snowman2
reviewed
Feb 8, 2023
snowman2
approved these changes
Feb 8, 2023
vincentsarago
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make an outer
with Env():optional when using an opened dataset as a context manager.Resolves #2759