Don't use approximate transformer with source_geoloc_array #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DFEvans
force-pushed
the
patch/dont_use_approximate_transformer_for_gcps
branch
from
b2b8030
to
02c584a
Compare
Fixes rasterio#3051 Using an approximate transformer alongside source_geoloc_array can lead to undesirable artefacts, presumably as it is difficult to fit an approximate function to a dense grid of points. Disable the use of approximate transformers in this case, as they already are for RPCs.
DFEvans
force-pushed
the
patch/dont_use_approximate_transformer_for_gcps
branch
from
02c584a
to
27b29d4
Compare
|
@DFEvans thanks! I'm 👀 on it now, re-running the failed CI jobs. |
snowman2
approved these changes
Apr 8, 2024
sgillies
pushed a commit
that referenced
this pull request
Apr 8, 2024
Fixes #3051 Using an approximate transformer alongside source_geoloc_array can lead to undesirable artefacts, presumably as it is difficult to fit an approximate function to a dense grid of points. Disable the use of approximate transformers in this case, as they already are for RPCs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3051
Using an approximate transformer alongside source_geoloc_array can lead to undesirable artefacts, presumably as it is difficult to fit an approximate function to a dense grid of points.
Disable the use of approximate transformers in this case, as they already are for RPCs.