Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Faraday Dependency #52

Closed
csholmes opened this issue Dec 19, 2019 · 1 comment · Fixed by #56
Closed

Update Faraday Dependency #52

csholmes opened this issue Dec 19, 2019 · 1 comment · Fixed by #56

Comments

@csholmes
Copy link

Ideally, this should be relaxed to '< 1.0', as any backwards-incompatible change should require a major version change.

The current dependency has been out of date since Faraday 0.16 was released on September 27, 2019.
@raszi
Copy link
Owner

raszi commented Dec 31, 2019 •
edited

Unfortunately this is not true for releases before the first final version (1.0.0).
They can change and break anytime according to semver spec

@samspills samspills mentioned this issue Jan 9, 2020
Merged
@raszi raszi closed this as completed in #56 Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump faraday + faraday_middleware version range samspills/mrkt
2 participants
@raszi @csholmes