chore: bump faraday + faraday_middleware version range #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faraday has released major version 1.0.0 (Jan 1 2020) faraday_middleware range was matching faraday, but set to be inline with its own releases (0.13.1, Feb 4 2019)
|
I was planning to wait until |
|
Ahh, I see. This is kind of a blocker for my team right now. Could I change the Faraday dependency to |
faraday_middleware doesn't support Faraday v1.0.0 yet
|
Hey @raszi, any thoughts about bumping to 0.17.3? As I mentioned this is a weird blocker for me right now. If you have any particular concerns I can add more tests to further verify that the new faraday version functions as expected? |
raszi
approved these changes
Jan 20, 2020
raszi
changed the title
|
Released as |
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday released version 1.0.0 on Jan 1 2020. I updated the faraday and faraday_middleware dependencies, and bumped the mrkt version from 0.11.0 to 0.11.1. I ran tests with
bundle exec rspecand everything looks good.Closes #52