Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional partner_id param to auth #47

Merged
merged 3 commits into from Dec 1, 2019

Conversation

tro2102
Copy link
Contributor

@tro2102 tro2102 commented Jun 17, 2019

Thanks for maintaining this repo, @raszi !

This PR adds the ability to specify an optional Marketo LaunchPoint partner_id, per their documentation and instructions.

This requirement was not obvious to us during initial implementation - it may be fairly new. But it appears they're selectively enforcing inclusion of this ID in the auth call for tracking purposes now.

@raszi
Copy link
Owner

raszi commented Jun 17, 2019

This is great! Could you please also update the README with the new option, then I would merge it right away.

@tro2102
Copy link
Contributor Author

tro2102 commented Jun 21, 2019

Done! Let me know if you'd prefer it in its own section instead of the basic example. I went back and forth between both options.

@raszi raszi merged commit 3ff249e into raszi:master Dec 1, 2019
@raszi
Copy link
Owner

raszi commented Dec 1, 2019

Sorry for the late response @tro2102. I needed to address a Travis issue before I could merge it.

@tro2102
Copy link
Contributor Author

tro2102 commented Dec 16, 2019

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants