fix tests, remove obsolete tests, add missing SIGINT handlers

raszi · Feb 3, 2020 · 78c72ef · 78c72ef
1 parent 05d1b43
commit 78c72ef
Show file tree

Hide file tree

Showing 11 changed files with 11 additions and 172 deletions.
diff --git a/lib/tmp.js b/lib/tmp.js
@@ -496,7 +496,6 @@ function _prepareRemoveCallback(removeFunction, fileOrDirName, sync, cleanupCall
  * @private
  */
 function _garbageCollector() {
-console.log(_gracefulCleanup);
   /* istanbul ignore else */
   if (!_gracefulCleanup) return;
 

diff --git a/test/issue129-sigint-test.js b/test/issue129-sigint-test.js
diff --git a/test/issue129-test.js b/test/issue129-test.js
diff --git a/test/mocha.opts b/test/mocha.opts
@@ -0,0 +1 @@
+--file ./test/setup-sigint-listener.js
diff --git a/test/outband/issue121.js b/test/outband/issue121.js
@@ -2,6 +2,10 @@
 
 const tmp = require('../../lib/tmp');
 
+process.on('SIGINT', function () {
+  process.exit(0);
+});
+
 process.on('SIGTERM', function () {
   process.exit(0);
 });

diff --git a/test/outband/issue129-sigint.js b/test/outband/issue129-sigint.js
diff --git a/test/outband/issue129-sigint.json b/test/outband/issue129-sigint.json
diff --git a/test/outband/issue129.js b/test/outband/issue129.js
diff --git a/test/outband/issue129.json b/test/outband/issue129.json
diff --git a/test/setup-sigint-listener.js b/test/setup-sigint-listener.js
@@ -0,0 +1,2 @@
+// make sure that all garbage gets collected on SIGINT
+process.on('SIGINT', process.exit);
diff --git a/test/spawn-generic.js b/test/spawn-generic.js
@@ -14,6 +14,10 @@ var fnUnderTest = null;
 if (config.async) fnUnderTest = (config.file) ? tmp.file : tmp.dir;
 else fnUnderTest = (config.file) ? tmp.fileSync : tmp.dirSync;
 
+// make sure that we have a SIGINT handler so CTRL-C the test suite
+// will not leave anything behing
+process.on('SIGINT', process.exit);
+
 // do we test against tmp doing a graceful cleanup?
 if (config.graceful) tmp.setGracefulCleanup();