feat: refactor app.rs #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
force-pushed
the
jm/refactor-app
branch
from
deba4e8
to
d30d427
Compare
kdheepak
force-pushed
the
jm/refactor-app
branch
from
fa9d712
to
0c5e8e1
Compare
kdheepak
reviewed
Feb 10, 2024
kdheepak
reviewed
Feb 10, 2024
|
I think it is worth merging this at this point and continuing a refactor if needed in a separate PR. It'll be easier to track changes that way. |
kdheepak
reviewed
Feb 10, 2024
joshka
force-pushed
the
jm/refactor-app
branch
from
2f54f37
to
f167143
Compare
|
joshka
commented
Feb 10, 2024
| } | ||
|
|
||
| fn status(&self) -> Block { | ||
| let line = if self.mode.is_filter() { |
There was a problem hiding this comment.
When there's this much difference in the if statements, the differences seem to outweigh the value of treating this as common. I'd pull this into the search.
Keybindings needs a "First Keybinding" type method to simplify this.
Sounds good. I'll start a round 2 PR on it later though as I think this can still be simplified a lot. |
Merged
|
We should leave the command ignore in there so users can override defaults |
kdheepak
added a commit
that referenced
this pull request
Feb 11, 2024
## 🤖 New release * `crates-tui`: 0.1.5 -> 0.1.6 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.6](v0.1.5...v0.1.6) - 2024-02-11 ### Added - refactor app.rs ([#21](#21)) - Increase spacing between top and bottom in summary ### Fixed - version string even without git ([#24](#24)) ### Other - Add AUR instructions ([#22](#22)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: Dheepak <1813121+kdheepak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to gradually refactor the app module to
split the search and summary functionality better. Right now app is a
module that has a bit of everything.
Don't merge this, I'll update this as I'm working through the refactor.
This PR refactors app.rs and adds a permanent statusbar.