Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor app.rs #21

Merged
merged 33 commits into from Feb 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
46ca871
wip: move search to Search
joshka Feb 9, 2024
1c44a8e
wip: move search to app::search::Search
joshka Feb 10, 2024
d185017
wip: move filter to search module
joshka Feb 10, 2024
b45b6a5
wip: move search_results field to search
joshka Feb 10, 2024
d9ce912
wip: move input into search page
joshka Feb 10, 2024
462ccd3
wip: rename search to SearchPage
joshka Feb 10, 2024
be0b1e1
wip: minor refactoring of key handling
joshka Feb 10, 2024
62d1f6c
wip: remove HandleFilterPromptChange
joshka Feb 10, 2024
333d50c
wip: move prompt to search page
joshka Feb 10, 2024
4ed2a92
wip: add SearchMode
joshka Feb 10, 2024
36e66eb
wip: start to refactor SearchFilterPromptWidget
joshka Feb 10, 2024
d30d427
wip: extract SearchPrompt out of SearchFilterPrompt
joshka Feb 10, 2024
9f36f64
wip: Move update_summary later on in the file
kdheepak Feb 10, 2024
ab355e0
wip: Remove unused import
kdheepak Feb 10, 2024
d73a292
wip: Move page, page_size and sort to SearchPage
kdheepak Feb 10, 2024
9a988be
wip: Move total_num_crates to SearchPage
kdheepak Feb 10, 2024
c1d9773
wip: Move arc mutex fields to search page
kdheepak Feb 10, 2024
2a5324c
wip: Move last_task_details_handle
kdheepak Feb 10, 2024
0c5e8e1
wip: Move all relevant methods to search page
kdheepak Feb 10, 2024
4b28400
wip: Move more methods to search page and filter prompt
kdheepak Feb 10, 2024
ba4a1e1
wip: Make search page a stateful widget
kdheepak Feb 10, 2024
56a5f64
wip: Add status bar widget and simplify prompt
kdheepak Feb 10, 2024
efa72d5
wip: Better status bar and prompt
kdheepak Feb 10, 2024
54d362f
wip: Remove search prompt for clarity
kdheepak Feb 10, 2024
988f160
wip: Refactor summary data into summary state
kdheepak Feb 10, 2024
037c075
wip: Group similar fields together
kdheepak Feb 10, 2024
375d7d5
wip: Don't show scrollbar in header area of table
kdheepak Feb 10, 2024
6b379bd
wip: Show crate info
kdheepak Feb 10, 2024
e1bc7f6
fix: Show Selected Tab as Search even when not in prompt
kdheepak Feb 10, 2024
3469ed2
wip: remove unused Ignore variant from Command and Action
joshka Feb 10, 2024
e97878d
wip: rename search_results_table to search_results and simplify scrol…
joshka Feb 10, 2024
add75b4
wip: use a half block for fancier looking scroll bar
joshka Feb 10, 2024
f167143
wip: simplify search results rendering
joshka Feb 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/widgets/search_results_table.rs
Expand Up @@ -101,6 +101,10 @@ impl StatefulWidget for SearchResultsTableWidget {
fn render(self, area: Rect, buf: &mut Buffer, state: &mut Self::State) {
let [area, scrollbar_area] =
Layout::horizontal([Constraint::Fill(1), Constraint::Length(1)]).areas(area);

let [_, scrollbar_area] =
Layout::vertical([Constraint::Length(3), Constraint::Fill(1)]).areas(scrollbar_area);

joshka marked this conversation as resolved.
Show resolved Hide resolved
Scrollbar::default()
.track_symbol(Some(" "))
.begin_symbol(None)
Expand Down