refactor(style): Mark some Style fns const so they can be defined globally #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindoodoo
approved these changes
Mar 24, 2023
orhun
approved these changes
Mar 24, 2023
sayanarijit
approved these changes
Mar 24, 2023
mindoodoo
changed the title
mindoodoo
approved these changes
Mar 24, 2023
a-kenji
added a commit
to a-kenji/ratatui
that referenced
this pull request
Jun 24, 2023
Mark functions of `structs` that suit themselves to be composed as const, namely: - `Block` - `Layout` - `Rect` Continuation of: ratatui-org#115
a-kenji
added a commit
to a-kenji/ratatui
that referenced
this pull request
Jun 24, 2023
Mark functions of `structs` that suit themselves to be composed as const, namely: - `Block` - `Layout` - `Rect` Continuation of: ratatui-org#115
a-kenji
added a commit
to a-kenji/ratatui
that referenced
this pull request
Jun 24, 2023
Mark functions of `structs` that suit themselves to be composed as const, namely: - `Block` - `Layout` - `Rect` Continuation of: ratatui-org#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows writing:
outside of a function. I can't mark
Style::default()asconstbecause it's from a trait.