feat(sparkline): finish #1 Sparkline directions PR #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename LTR/RTL to LeftToRight/RightToLeft - add tests
joshka
force-pushed
the
218/sparklineDirection
branch
from
686e28e
to
8a3e1d0
Compare
Thanks! :) |
orhun
approved these changes
Apr 13, 2023
mindoodoo
approved these changes
Apr 14, 2023
mindoodoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #1
I'm unsure how exactly to update PR #1 (which is a copy of another user's fork that is a PR against tui-rs). I didn't find an obvious way to do this using git or github, so went with cutting a branch in my fork and doing a new PR from there. If I've missed something obvious, please let me know. I know that it's fairly easy to do when you own the repo and the original requester marks the PR as updatable by maintainers, but this has several edge cases on top.