Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): expose test buffer #160

Merged
merged 1 commit into from
May 4, 2023
Merged

feat(test): expose test buffer #160

merged 1 commit into from
May 4, 2023

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented May 1, 2023

Allow a way to expose the buffer of the TestBackend, to easier support different testing methodologies.

@a-kenji
Copy link
Contributor Author

a-kenji commented May 1, 2023

Superceded by #161,
assuming to_test_string() stays in the public interface.

@a-kenji a-kenji closed this May 1, 2023
joshka
joshka reviewed May 1, 2023
View reviewed changes
src/backend/test.rs Outdated Show resolved Hide resolved
@a-kenji a-kenji deleted the expose-test-buffer branch May 1, 2023 10:24
@a-kenji a-kenji restored the expose-test-buffer branch May 1, 2023 16:52
@a-kenji
Copy link
Contributor Author

a-kenji commented May 1, 2023

Reopening, since It seems that this approach is more suited to my immediate needs, after looking closer at #161.

@a-kenji a-kenji reopened this May 1, 2023
@a-kenji
feat(test): expose test buffer
d4c3078 
Allow a way to expose the buffer of the `TestBackend`,
to easier support different testing methodologies.
joshka
joshka approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the code from buffer_view() into fmt(). But approved regardless as this seems useful.

src/backend/test.rs Show resolved Hide resolved
sophacles
sophacles approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@sophacles sophacles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@orhun orhun merged commit 86c3fc9 into ratatui-org:main May 4, 2023
7 checks passed
@joshka joshka mentioned this pull request Jun 26, 2023
Closed
@a-kenji a-kenji deleted the expose-test-buffer branch July 17, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@sophacles sophacles sophacles approved these changes

@orhun orhun orhun approved these changes

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a-kenji @sophacles @joshka @orhun