-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add backend docs #213
Conversation
Codecov Report
@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 34 34
Lines 6572 6572
=======================================
Hits 5367 5367
Misses 1205 1205
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the doc comments on the Backend
trait methods implemented by the different backends ? My understanding is that doc comments on the methods defined in the trait definition would propagate to the traits implementation unless overriden. After skimming through them real quick it seems that for the most part they are pretty much the same as the doc comments on the trait definition.
Lmk what you think, otherwise this was greatly needed, thanks for the PR !
Yep - you're right, will remove the unnecessary text. |
I really should have checked that output more thoroughly - update incoming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.