chore(demo): update demo gif with a fixed unicode gauge #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joshka
commented
Jun 8, 2023
joshka
commented
- fix(gauge): render gauge with unicode correctly
- docs: update demo.gif
|
Before: 
After: 
I think the color issue is possibly because the space doesn't have a bold rendering? |
Gauge now correctly renders a block rather than a space when in unicode mode.
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 81.68% 81.70% +0.01%
==========================================
Files 34 34
Lines 6579 6586 +7
==========================================
+ Hits 5374 5381 +7
Misses 1205 1205
|
orhun
reviewed
Jun 8, 2023
- remove existing gif - upload using VHS (https://github.com/charmbracelet/vhs) - add instructions to RELEASE.md - link new gif in README
sayanarijit
approved these changes
Jun 11, 2023
orhun
approved these changes
Jun 11, 2023
orhun
changed the title
samyosm
pushed a commit
to samyosm/ratatui
that referenced
this pull request
Jun 18, 2023
) * fix(gauge): render gauge with unicode correctly Gauge now correctly renders a block rather than a space when in unicode mode. * docs: update demo.gif - remove existing gif - upload using VHS (https://github.com/charmbracelet/vhs) - add instructions to RELEASE.md - link new gif in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.