chore(features): enable building with all-features #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, it wasn't possible to build all features and all targets at the same time, which prevents rust-analyzer from working for the whole project. Adds a bacon.toml file to the project, which is used by bacon https://dystroy.org/bacon/ Configures docs.rs to show the feature flags that are necessary to make modules / types / functions available.
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
sophacles
as code owners
|
E.g.: E.g: |
joshka
commented
Jun 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 36 36
Lines 7360 7360
=======================================
Hits 6088 6088
Misses 1272 1272
|
|
One of the big benefits of this is that it reduces the need to do specific CI builds for each backend, and instead we can just use https://github.com/taiki-e/cargo-hack to do all features / feature power sets, while just building once with all-features locally for speed. |
sophacles
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it wasn't possible to build all features and all
targets at the same time, which prevents rust-analyzer from working
for the whole project.
Adds a bacon.toml file to the project, which is used by bacon
https://dystroy.org/bacon/
Configures docs.rs to show the feature flags that are necessary to
make modules / types / functions available.