feat(stylize): allow all widgets to be styled #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
sophacles
as code owners
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 83.85% 85.00% +1.15%
==========================================
Files 38 38
Lines 8045 8464 +419
==========================================
+ Hits 6746 7195 +449
+ Misses 1299 1269 -30
|
|
I thought we were putting macro code behind |
Yep. Just user facing macros makes sense. Here they cut down on hundreds of LoC so that’s really useful. |
joshka
force-pushed
the
feat-stylize-all-the-things
branch
2 times, most recently
from
5277c79
to
e8a95d3
Compare
|
(rebased on main) |
joshka
force-pushed
the
feat-stylize-all-the-things
branch
from
e8a95d3
to
42d5432
Compare
joshka
force-pushed
the
feat-stylize-all-the-things
branch
from
42d5432
to
2b4ea4d
Compare
|
Rebased on main to resolve conflicts with prelude introduction and barchart changes (barchart.rs -> barchart/mod.rs). |
joshka
force-pushed
the
feat-stylize-all-the-things
branch
2 times, most recently
from
5373442
to
b24c82e
Compare
sayanarijit
approved these changes
Jul 14, 2023
|
This is cool... |
- Add styled impl to: - Barchart - Chart (including Axis and Dataset), - Guage and LineGuage - List and ListItem - Sparkline - Table, Row, and Cell - Tabs - Style - Allow modifiers to be removed (e.g. .not_italic()) - Allow .bg() to recieve Into<Color> - Made shorthand methods consistent with modifier names (e.g. dim() not dimmed() and underlined() not underline()) - Simplify integration tests - Add doc comments - Simplified stylize macros with https://crates.io/crates/paste
Runny clippy first means that we fail fast when there is an issue that can easily be fixed rather than having to wait 30-40s for the failure
joshka
force-pushed
the
feat-stylize-all-the-things
branch
from
b24c82e
to
49152db
Compare
|
Fixed up doc tests problem that I introduced by adding more docs. |
mindoodoo
approved these changes
Jul 14, 2023
a-kenji
pushed a commit
to a-kenji/ratatui
that referenced
this pull request
Jul 16, 2023
* feat(stylize): allow all widgets to be styled - Add styled impl to: - Barchart - Chart (including Axis and Dataset), - Guage and LineGuage - List and ListItem - Sparkline - Table, Row, and Cell - Tabs - Style - Allow modifiers to be removed (e.g. .not_italic()) - Allow .bg() to recieve Into<Color> - Made shorthand methods consistent with modifier names (e.g. dim() not dimmed() and underlined() not underline()) - Simplify integration tests - Add doc comments - Simplified stylize macros with https://crates.io/crates/paste * build: run clippy before tests Runny clippy first means that we fail fast when there is an issue that can easily be fixed rather than having to wait 30-40s for the failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Stylizeimplementations for all the remaining widgetsStyle::new().blue()Style::new().not_bold()Details:
dimmed() and underlined() not underline())