fix(prelude): remove widgets module from prelude #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
sophacles
as code owners
This helps to keep the prelude small and less likely to conflict with other crates. - remove widgets module from prelude as the entire module can be just as easily imported with `use ratatui::widgets::*;` - move prelude module into its own file - update examples to import widgets module instead of just prelude - added several modules to prelude to make it possible to qualify imports that collide with other types that have similar names
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 38 38
Lines 8507 8507
=======================================
Hits 7231 7231
Misses 1276 1276
|
sayanarijit
approved these changes
Jul 16, 2023
|
Will wait on a second review on this one rather than merging. |
mindoodoo
approved these changes
Jul 16, 2023
orhun
approved these changes
Jul 16, 2023
a-kenji
pushed a commit
to a-kenji/ratatui
that referenced
this pull request
Jul 16, 2023
This helps to keep the prelude small and less likely to conflict with other crates. - remove widgets module from prelude as the entire module can be just as easily imported with `use ratatui::widgets::*;` - move prelude module into its own file - update examples to import widgets module instead of just prelude - added several modules to prelude to make it possible to qualify imports that collide with other types that have similar names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to keep the prelude small and less likely to conflict with
other crates.
easily imported with
use ratatui::widgets::*;imports that collide with other types that have similar names
Note
In the discussion of this on discord, just the canvas was suggested to be removed, however given that it's fairly easy to import widgets::*, it makes sense to drop the entire module from the prelude.