Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(title): remove default alignment and position #323

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

orhun
Copy link
Sponsor Member

@orhun orhun commented Jul 16, 2023

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #323 (d74c362) into main (446efae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d74c362 differs from pull request most recent head 35bc456. Consider uploading reports for the commit 35bc456 to get more accurate results

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   85.00%   85.01%   +0.01%     
==========================================
  Files          38       40       +2     
  Lines        8507     8570      +63     
==========================================
+ Hits         7231     7286      +55     
- Misses       1276     1284       +8     
Impacted Files Coverage Δ
src/title.rs 100.00% <100.00%> (ø)
src/widgets/block.rs 87.40% <100.00%> (+1.00%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change to me. Can you please write a test for this (in the block unit tests) that covers the bug mentioned in #322

@orhun
Copy link
Sponsor Member Author

orhun commented Jul 17, 2023

Added test cases for both usages of alignment.

@orhun orhun requested a review from joshka July 17, 2023 09:37
src/widgets/block.rs Outdated Show resolved Hide resolved
@orhun orhun requested a review from joshka July 17, 2023 10:26
@joshka joshka added this pull request to the merge queue Jul 17, 2023
Merged via the queue into ratatui-org:main with commit 1ff8553 Jul 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title_alignment does not work as expected
2 participants