build: forbid unsafe code #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This indicates good (high level) code and is used by tools like cargo-geiger.
EdJoPaTo
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
joshka
as code owners
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 40 40
Lines 8590 8590
=======================================
Hits 7306 7306
Misses 1284 1284 |
joshka
approved these changes
Jul 17, 2023
sayanarijit
approved these changes
Jul 17, 2023
mindoodoo
approved these changes
Jul 18, 2023
|
Thanks @EdJoPaTo for the code contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indicates good (high level) code and is used by tools like cargo-geiger.
Reading #66 it also sounds like a good idea to have this unless someone has a really good explanation to remove this.
Also see #157 (comment)