chore: implement Clone & Copy common traits
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TieWay59
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
mindoodoo
changed the title
Clone & Copy common traitsClone & Copy common traits
mindoodoo
reviewed
Jul 27, 2023
joshka
requested changes
Jul 27, 2023
TieWay59
force-pushed
the
impl-clone-copy
branch
from
c9d6c4a
to
a725684
Compare
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 84.76% 84.76%
=======================================
Files 40 40
Lines 8603 8603
=======================================
Hits 7292 7292
Misses 1311 1311
|
mindoodoo
approved these changes
Jul 28, 2023
joshka
approved these changes
Jul 28, 2023
Implement `Clone & Copy` common traits for most structs in src.
Only implement `Copy` for structs that are simple and trivial to copy.
Reorder the derive fields to be more consistent:
Debug, Default, Clone, Copy, Eq, PartialEq, Ord, PartialOrd, Hash
see: ratatui-org#307
|
Thanks again for the great effort on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Clone & Copycommon traits for most structs in src.Only implement
Copyfor structs that are simple and trivial to copy.Reorder the derive fields to be more consistent:
see: #307