-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement Eq & PartialEq
common traits
#357
Conversation
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 84.84% 84.76% -0.09%
==========================================
Files 40 40
Lines 8627 8603 -24
==========================================
- Hits 7320 7292 -28
- Misses 1307 1311 +4
|
The CI / check failed at: error: package `time v0.3.24` cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.67.0 or newer, or use
cargo update -p time@0.3.24 --precise ver
where `ver` is the latest version of `time` supporting rustc 1.65.0
[cargo-make] ERROR - Error while executing command, exit code: 101
[cargo-make] WARN - Build Failed.
Error: Process completed with exit code 1. But I didn't have this error at my local env because I have higher version of rust tool chain: ~/rusty/ratatui> rustup --version 08/01/2023 10:56:42 AM
rustup 1.26.0 (5af9b9484 2023-04-05)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.71.0 (8ede3aae2 2023-07-12)`
~/rusty/ratatui> cargo --version 08/01/2023 10:58:37 AM
cargo 1.71.0 (cfd3bbd8f 2023-06-08)
~/rusty/ratatui> rustc --version 08/01/2023 10:58:43 AM
rustc 1.71.0 (8ede3aae2 2023-07-12) @joshka I suppose we should working on bump-up the rust version in other PR. |
#361 bumps the MSRV. |
LGTM thanks again |
Reorder the derive fields to be more consistent: Debug, Default, Clone, Copy, Eq, PartialEq, Ord, PartialOrd, Hash see: ratatui-org#307
Also reorder some derive fields to be more consistent:
see: #307