Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement Eq & PartialEq common traits #357

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

TieWay59
Copy link
Contributor

Also reorder some derive fields to be more consistent:

Debug, Default, Clone, Copy, Eq, PartialEq, Ord, PartialOrd, Hash

see: #307

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #357 (a65cab8) into main (554805d) will decrease coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 46.66%.

❗ Current head a65cab8 differs from pull request most recent head 0162b1f. Consider uploading reports for the commit 0162b1f to get more accurate results

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   84.84%   84.76%   -0.09%     
==========================================
  Files          40       40              
  Lines        8627     8603      -24     
==========================================
- Hits         7320     7292      -28     
- Misses       1307     1311       +4     
Files Changed Coverage Δ
src/backend/crossterm.rs 0.00% <0.00%> (ø)
src/backend/mod.rs 33.33% <0.00%> (ø)
src/backend/termion.rs 27.46% <0.00%> (ø)
src/backend/test.rs 43.63% <0.00%> (ø)
src/terminal.rs 55.73% <0.00%> (ø)
src/widgets/calendar.rs 81.06% <0.00%> (ø)
src/widgets/canvas/circle.rs 97.14% <0.00%> (ø)
src/widgets/canvas/line.rs 59.67% <0.00%> (ø)
src/widgets/canvas/map.rs 0.00% <0.00%> (ø)
src/widgets/canvas/mod.rs 91.61% <0.00%> (ø)
... and 20 more

@TieWay59
Copy link
Contributor Author

TieWay59 commented Aug 1, 2023

The CI / check failed at:

error: package `time v0.3.24` cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.67.0 or newer, or use
cargo update -p time@0.3.24 --precise ver
where `ver` is the latest version of `time` supporting rustc 1.65.0
[cargo-make] ERROR - Error while executing command, exit code: 101
[cargo-make] WARN - Build Failed.
Error: Process completed with exit code 1.

But I didn't have this error at my local env because I have higher version of rust tool chain:

~/rusty/ratatui> rustup --version                                                                                                                      08/01/2023 10:56:42 AM
rustup 1.26.0 (5af9b9484 2023-04-05)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.71.0 (8ede3aae2 2023-07-12)`
~/rusty/ratatui> cargo --version                                                                                                                       08/01/2023 10:58:37 AM
cargo 1.71.0 (cfd3bbd8f 2023-06-08)
~/rusty/ratatui> rustc --version                                                                                                                       08/01/2023 10:58:43 AM
rustc 1.71.0 (8ede3aae2 2023-07-12)

@joshka I suppose we should working on bump-up the rust version in other PR.

@joshka
Copy link
Member

joshka commented Aug 4, 2023

#361 bumps the MSRV.

@joshka
Copy link
Member

joshka commented Aug 4, 2023

LGTM thanks again

@joshka joshka enabled auto-merge August 4, 2023 08:21
Reorder the derive fields to be more consistent:

    Debug, Default, Clone, Copy, Eq, PartialEq, Ord, PartialOrd, Hash

see: ratatui-org#307
@joshka joshka added this pull request to the merge queue Aug 4, 2023
Merged via the queue into ratatui-org:main with commit 181706c Aug 4, 2023
9 of 28 checks passed
@joshka joshka added this to the v0.23.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants