feat(block): support placing the title on bottom #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rabirabirara The test you added seems to be failing. |
|
I have a fix for the tests added, appears the expected behaviors were incorrectly input. Added a pull request for the branch here so this can be merged: #88 |
|
Merged #88 into this branch, however, note that since it's a new feature, it's still out of scope for the initial release. |
sayanarijit
force-pushed
the
669/title_on_bottom
branch
from
9f8333a
to
240738b
Compare
mindoodoo
approved these changes
Mar 23, 2023
|
Seems like a small useful feature, I'm in favor of adding it in. Thoughts @sayanarijit @orhun ? |
|
Yup, I agree. (approved) |
|
Thank you for implementing this feature! (Am author of fdehau/tui-rs#625) |
orhun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before you could only put the title on the top row of a block. Now you can put it on the bottom row! Revolutionary.
In the future, implementing an option for both a bottom and top title is possible, but seems unnecessary considering you could just manually have a
Layoutand do the work yourself at that point, and having support for title wizardry seems pointless. The farthest you could go is having an option to actually move the title everywhere; it's an easy extension and seems like something that would normally be built-in. Hence here it is; you can do top and bottom, left right and center.Testing guidelines
When creating a
Blockwith, say,Block::default().title(), slap on a.title_on_bottom(). Checktests/widget_block.rsfor the tests, which are just a copy of the alignment tests.Checklist