Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(coverage): exclude examples directory from coverage #373

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 5, 2023

Closes: #372

Alternative: Use cargo make also in bacon, that way updates need to be only made in the Makefile.toml

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #373 (adc1056) into main (e18393d) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   84.99%   84.99%           
=======================================
  Files          40       40           
  Lines        8686     8686           
=======================================
  Hits         7383     7383           
  Misses       1303     1303           

see 1 file with indirect coverage changes

@joshka
Copy link
Member

joshka commented Aug 5, 2023

I thought this would probably be via https://docs.codecov.com/docs/ignoring-paths rather than tweaking the lcov output. Not 100% sure though as I haven't looked deeply. Do you have any guidance on that?

@orhun
Copy link
Sponsor Member

orhun commented Aug 6, 2023

Yeah, this should be done via ignore directive in codecov.yml

@a-kenji
Copy link
Contributor Author

a-kenji commented Aug 7, 2023

I wasn't sure about the change.

This:

Since Codecov works by ingesting your coverage reports from the testing tools, the key component needed for the integration is the ability to upload a coverage report (ideally from your CI provider) to Codecov.

Lead me to believe if we exclude the directory from the report itself, it wouldn't be ingested. But that doesn't seem what is happening.

I'll add a configuration file.

@joshka joshka added this pull request to the merge queue Aug 7, 2023
Merged via the queue into ratatui-org:main with commit de9f52f Aug 7, 2023
30 checks passed
@a-kenji a-kenji deleted the ignore-examples branch August 7, 2023 12:42
@joshka joshka added this to the v0.23.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore examples in code coverage
3 participants